Skip to content

Remove unnused setting in daemon claim config #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2025
Merged

Remove unnused setting in daemon claim config #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions api/nvidia.com/resource/v1beta1/computedomainconfig.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ func (c *ComputeDomainChannelConfig) Validate() error {
// ComputeDomainDaemonConfig holds the set of parameters for configuring an ComputeDomainDaemon.
type ComputeDomainDaemonConfig struct {
metav1.TypeMeta `json:",inline"`
NumNodes int `json:"numNodes"`
DomainID string `json:"domainID"`
}

Expand All @@ -79,9 +78,6 @@ func (c *ComputeDomainDaemonConfig) Normalize() error {

// Validate ensures that ComputeDomainDaemonConfig has a valid set of values.
func (c *ComputeDomainDaemonConfig) Validate() error {
if c.NumNodes <= 0 {
return fmt.Errorf("numNodes must be greater than or equal to 1")
}
if c.DomainID == "" {
return fmt.Errorf("domainID cannot be empty")
}
Expand Down
1 change: 0 additions & 1 deletion cmd/compute-domain-controller/resourceclaimtemplate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,6 @@ func (m *DaemonSetResourceClaimTemplateManager) Create(ctx context.Context, name
}

daemonConfig := nvapi.DefaultComputeDomainDaemonConfig()
daemonConfig.NumNodes = cd.Spec.NumNodes
daemonConfig.DomainID = string(cd.UID)

templateData := ResourceClaimTemplateTemplateData{
Expand Down
1 change: 0 additions & 1 deletion templates/compute-domain-daemon-claim-template.tmpl.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,4 @@ spec:
parameters:
apiVersion: {{ .DaemonConfig.APIVersion }}
kind: {{ .DaemonConfig.Kind }}
numNodes: {{ .DaemonConfig.NumNodes }}
domainID: {{ .DaemonConfig.DomainID }}