Skip to content

Add CI target to check generated code #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2025
Merged

Add CI target to check generated code #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40b67a4
Add check-generate target to makefile
elezar Feb 15, 2025
3c56450
Add CI target for generated code
elezar Feb 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/golang.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,16 @@ jobs:
args: -v --timeout 5m
skip-cache: true

- name: Check golang modules
- name: Golang modules
run: |
make check-modules
make -C deployments/devel check-modules

- name: Generated code
run: |
make -C deployments/devel install-tools
make check-generate

test:
name: Unit test
runs-on: ubuntu-latest
Expand Down
5 changes: 4 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ endif
CMDS := $(patsubst ./cmd/%/,%,$(sort $(dir $(wildcard ./cmd/*/))))
CMD_TARGETS := $(patsubst %,cmd-%, $(CMDS))

CHECK_TARGETS := golangci-lint
CHECK_TARGETS := golangci-lint check-generate
MAKE_TARGETS := binaries build build-image check fmt lint-internal test examples cmds coverage generate vendor check-modules $(CHECK_TARGETS)

TARGETS := $(MAKE_TARGETS) $(CMD_TARGETS)
Expand Down Expand Up @@ -113,6 +113,9 @@ generate-crds: generate-deepcopy .remove-crds
rm -rf $(CURDIR)/deployments/helm/tmp_crds


check-generate: generate
git diff --exit-code HEAD

generate-deepcopy: .remove-deepcopy
for dir in $(DEEPCOPY_SOURCES); do \
controller-gen \
Expand Down
Loading