Clean up resourceSlices during exit #186
Conversation
ArangoGutierrez
left a comment
ArangoGutierrez
left a comment
There was a problem hiding this comment.
Thanks for the Help @klueska
cmd/nvidia-dra-controller/main.go
Outdated
| defer func() { | ||
| cancel() | ||
| if err := imexManager.Stop(); err != nil { | ||
| klog.Errorf("error stopping IMEX manager: %v", err) |
There was a problem hiding this comment.
| klog.Errorf("error stopping IMEX manager: %v", err) | |
| klog.Errorf("Error stopping IMEX manager: %v", err) |
There was a problem hiding this comment.
oh I forgot linters don't like capitalized error messages
There was a problem hiding this comment.
Reverted this change, to comply with the linter
There was a problem hiding this comment.
There was a problem hiding this comment.
Running [/home/runner/golangci-lint-1.61.0-linux-amd64/golangci-lint run -v --timeout 5m] in [/home/runner/work/k8s-dra-driver/k8s-dra-driver] ...
Error: cmd/nvidia-dra-controller/imex.go:309:11: ST1005: error strings should not be capitalized (stylecheck)
return fmt.Errorf("Error deleting resource slice %s: %w", rs.Name, err)There was a problem hiding this comment.
Maybe your golangci-lint or go versions are different from the one we have on CI
There was a problem hiding this comment.
That is not the correct line you are changing. That one should be lower case because it is a return statement. The line I'm requesting to change is the klog line which should be uppercase.
There was a problem hiding this comment.
Done, I understood my error, I was looking into the wrong line
ArangoGutierrez
force-pushed
the
107/131
branch
2 times, most recently
from
6beddd6 to
0bc9bb6
Compare
|
Ready for a last review |
|
Can you squash these into one commit |
ArangoGutierrez
force-pushed
the
107/131
branch
from
0bc9bb6 to
639192c
Compare
done |
|
Once you have addressed https://github.com/NVIDIA/k8s-dra-driver/pull/186/files#r1812822764 I think we ae good to go. |
Add more synchronization around the shutdown of the IMEX manager Signed-off-by: Kevin Klues <[email protected]> Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
ArangoGutierrez
force-pushed
the
107/131
branch
from
639192c to
8338ab5
Compare
Clean up resourceSlices during exit
Clean up resourceSlices during exit
Clean up resourceSlices during exit
github-project-automation
bot
moved this to Backlog
in Planning Board: k8s-dra-driver-gpu
2 participants
No description provided.