Skip to content

Enable NodeFeature API by default in GFD #1504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable NodeFeature API by default in GFD #1504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cmd/gpu-feature-discovery/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ func main() {
},
&cli.BoolFlag{
Name: "use-node-feature-api",
Value: true,
Usage: "Use NFD NodeFeature API to publish labels",
EnvVars: []string{"GFD_USE_NODE_FEATURE_API", "USE_NODE_FEATURE_API"},
},
Expand Down
2 changes: 1 addition & 1 deletion deployments/helm/nvidia-device-plugin/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ gfd:
# Helm dependency
nfd:
nameOverride: node-feature-discovery
enableNodeFeatureApi: false
enableNodeFeatureApi: true
Copy link
Member

@elezar elezar Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the behaviour differ between upgrades and new installations due to this toggle?

Copy link
Contributor Author

@rajathagasthya rajathagasthya Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should automatically upgrade to using NFD when a new chart and device plugin image is used, so I don't think the behavior differs. Is there a particular scenario you were thinking of?

Copy link
Contributor

@cdesiniotis cdesiniotis Nov 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the answer is yes, but just to confirm -- if we upgrade the device-plugin helm chart, does the NFD subchart also get upgraded and the value of this field, enableNodeFeatureApi, gets toggled from false to true?

Copy link
Contributor Author

@rajathagasthya rajathagasthya Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elezar Do you have any thoughts on if we should keep this value enabled by default?

Copy link
Contributor

@cdesiniotis cdesiniotis Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rajathagasthya have you tried a helm chart upgrade? What behavior have you observed?

master:
serviceAccount:
name: node-feature-discovery
Expand Down