Deduplicate requested device IDs #1434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elezar
force-pushed
the
deduplicate-device-requests
branch
from
5d73d27 to
5aef9c1
Compare
Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
This change ensures that the incoming device IDs are deduplicated before updating the AllocateResponse. This avoids cases where the NVIDIA_VISIBLE_DEVICES envvar or CDI annotations contain repeated device UUIDs or INDICES that do not add additional modifications to the container. Signed-off-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
deduplicate-device-requests
branch
from
5aef9c1 to
75633e2
Compare
ArangoGutierrez
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that the incoming device IDs are deduplicated before updating the AllocateResponse. This avoids cases where the
NVIDIA_VISIBLE_DEVICESenvvar orCDIannotations contain repeated device UUIDs or INDICES that do not add additional modifications to the container.Fixes #1432