Enable the use of CDI on OpenShift #733
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…disabled Signed-off-by: Christopher Desiniotis <[email protected]>
This commit configures the toolkit container and device-plugin appropriately so that CDI can be used to provide GPU access to both management and application containers on OpenShift. On OpenShift, we cannot set 'nvidia' as the default runtime. Because of this, we have decided to take a hybrid approach for enabling CDI. That is, we use the 'nvidia' runtime configured in CDI mode for providing GPU access to management containers, and native CDI support in CRI-O for providing GPU access to application containers. Signed-off-by: Christopher Desiniotis <[email protected]>
|
Glad to see the official CDI support on OpenShift. Just a side question: Why not always use |
shivamerla
reviewed
Sep 6, 2024
| // being used and CDI is not enabled. In this case, an OCI hook is used and the nvidia | ||
| // runtime is not configured. | ||
| func setRuntimeClass(podSpec *corev1.PodSpec, n ClusterPolicyController, runtimeClass string) { | ||
| if n.runtime == gpuv1.CRIO && !n.singleton.Spec.CDI.IsEnabled() { |
Contributor
There was a problem hiding this comment.
doesn't this enable for docker too?
|
This PR is stale because it has been open 90 days with no activity. This PR will be closed in 30 days unless new comments are made or the stale label is removed. To skip these checks, apply the "lifecycle/frozen" label. |
github-actions
bot
added
the
lifecycle/stale
Contributor
Author
|
Closing in favor of #1578 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.