Skip to content

[fix] : add namespace when templating helm chart #1904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2025
Merged

[fix] : add namespace when templating helm chart #1904

merged 1 commit into from
Nov 20, 2025
+4 −0

Conversation

@rahulait
Copy link
Contributor

@rahulait rahulait commented Nov 17, 2025

Fixes #754

@copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 17, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@cdesiniotis cdesiniotis added this to the v25.10.1 milestone Nov 17, 2025
tariq1890
tariq1890 reviewed Nov 17, 2025
View reviewed changes
tariq1890
tariq1890 reviewed Nov 17, 2025
View reviewed changes
@cdesiniotis
Copy link
Contributor

cdesiniotis commented Nov 17, 2025

/cherry-pick release-25.10

@rahulait rahulait force-pushed the fix-template-namespace branch from 0f9621c to c14dc6b Compare November 17, 2025 23:19
@rahulait rahulait requested a review from tariq1890 November 17, 2025 23:27
@rahulait rahulait force-pushed the fix-template-namespace branch from c14dc6b to 35e4621 Compare November 17, 2025 23:31
@rahulait
Copy link
Contributor Author

rahulait commented Nov 17, 2025

/ok to test 35e4621

tariq1890
tariq1890 reviewed Nov 17, 2025
View reviewed changes
@rahulait rahulait force-pushed the fix-template-namespace branch from 35e4621 to d3ce312 Compare November 18, 2025 00:13
@rahulait
Copy link
Contributor Author

rahulait commented Nov 18, 2025

/ok to test d3ce312

@rahulait rahulait requested a review from tariq1890 November 18, 2025 00:15
tariq1890
tariq1890 reviewed Nov 19, 2025
View reviewed changes
tariq1890
tariq1890 reviewed Nov 19, 2025
View reviewed changes
@rahulait rahulait force-pushed the fix-template-namespace branch from d3ce312 to 49c4815 Compare November 19, 2025 23:21
@rahulait rahulait requested a review from tariq1890 November 19, 2025 23:22
@rahulait
Copy link
Contributor Author

rahulait commented Nov 19, 2025

/ok to test 49c4815

tariq1890
tariq1890 approved these changes Nov 19, 2025
View reviewed changes
Copy link
Contributor

@tariq1890 tariq1890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rahulait !

@tariq1890 tariq1890 enabled auto-merge November 19, 2025 23:25
@tariq1890 tariq1890 merged commit 5c5f325 into NVIDIA:main Nov 20, 2025
29 of 30 checks passed
@github-actions github-actions bot mentioned this pull request Nov 20, 2025
Merged
@github-actions
Copy link

github-actions bot commented Nov 20, 2025

🤖 Backport PR created for release-25.10: #1914 ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tariq1890 tariq1890 tariq1890 approved these changes

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez ArangoGutierrez is a code owner

@cdesiniotis cdesiniotis Awaiting requested review from cdesiniotis cdesiniotis is a code owner

@elezar elezar Awaiting requested review from elezar elezar is a code owner

@shivamerla shivamerla Awaiting requested review from shivamerla shivamerla is a code owner

Assignees

No one assigned

Labels

cherry-pick/release-25.10

Projects

None yet

Milestone

v25.10.1

Development

Successfully merging this pull request may close these issues.

User "system:serviceaccount:default:gpu-operator" cannot list resource "daemonsets" in API group "apps" at the cluster scope with Helm Template

3 participants

@rahulait @cdesiniotis @tariq1890