Skip to content

Conversation

@karthikvetrivel
Copy link
Member

@karthikvetrivel karthikvetrivel commented Oct 24, 2025

Replace custom utility functions (BoolPtr(), Int64Ptr(), newHostPathType()) with the standard ptr.To() from k8s.io/utils/ptr package.

@karthikvetrivel karthikvetrivel force-pushed the refactor/extract-hostpathtype-util branch from 7cd9dbe to f27737e Compare October 24, 2025 14:20
@karthikvetrivel karthikvetrivel changed the title Extract newHostPathType to public HostPathTypePtr utility function [refactor] Extract newHostPathType to public HostPathTypePtr utility function Oct 24, 2025
@karthikvetrivel karthikvetrivel changed the title [refactor] Extract newHostPathType to public HostPathTypePtr utility function [refactor] Replace custom pointer helpers with k8s.io/utils/ptr.To() Oct 27, 2025
@tariq1890
Copy link
Contributor

LGTM. Please squash the commit history and we can merge

@karthikvetrivel karthikvetrivel force-pushed the refactor/extract-hostpathtype-util branch from 792459f to 22d3263 Compare October 28, 2025 18:24
@karthikvetrivel
Copy link
Member Author

Squashed.

@tariq1890 tariq1890 enabled auto-merge October 28, 2025 18:38
@tariq1890 tariq1890 merged commit 109f67e into NVIDIA:main Oct 28, 2025
15 of 16 checks passed
@tariq1890
Copy link
Contributor

/cherry-pick release-25.10

@github-actions
Copy link

🤖 Backport PR created for release-25.10: #1919

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants