[refactor] Remove duplicated VGPU constants from controllers and use internal/consts package #1831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsts package Signed-off-by: Karthik Vetrivel <[email protected]>
karthikvetrivel
requested review from
ArangoGutierrez,
cdesiniotis,
elezar,
shivamerla and
tariq1890
as code owners
karthikvetrivel
changed the title
tariq1890
approved these changes
Oct 29, 2025
Contributor
tariq1890
left a comment
tariq1890
left a comment
There was a problem hiding this comment.
Thanks @karthikvetrivel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes duplicated VGPU-related constants (VGPULicensingConfigMountPath, VGPULicensingFileName, NLSClientTokenMountPath, NLSClientTokenFileName, VGPUTopologyConfigMountPath, VGPUTopologyConfigFileName) from the controllers package. All references now use the constants from the internal/consts package, establishing a single source of truth.