Replace kubectl usage with utility program to apply CRDs #1802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajathagasthya
force-pushed
the
remove-kubectl
branch
from
a6b1915 to
dd530cd
Compare
elezar
reviewed
Oct 22, 2025
elezar
reviewed
Oct 22, 2025
cmd/apply-crds/main.go
Outdated
| &cli.StringSliceFlag{ | ||
| Name: "crds-path", | ||
| Usage: "Path to CRD manifest file or directory (can be specified multiple times, directories are searched recursively)", | ||
| Required: true, |
Contributor
Author
There was a problem hiding this comment.
I don't think it's necessary. I could it see DEBUG env above being useful, but I don't anticipate users wanting to set an env with these paths.
elezar
reviewed
Oct 22, 2025
elezar
reviewed
Oct 22, 2025
elezar
reviewed
Oct 22, 2025
elezar
reviewed
Oct 22, 2025
elezar
reviewed
Oct 22, 2025
tariq1890
reviewed
Oct 22, 2025
tariq1890
reviewed
Oct 22, 2025
rajathagasthya
force-pushed
the
remove-kubectl
branch
2 times, most recently
from
a82dbba to
05279b1
Compare
rajathagasthya
requested review from
ArangoGutierrez,
cdesiniotis and
shivamerla
as code owners
tariq1890
approved these changes
Oct 28, 2025
rajathagasthya
force-pushed
the
remove-kubectl
branch
from
05279b1 to
19567dd
Compare
cdesiniotis
reviewed
Oct 28, 2025
kubectl is heavyweight and often has CVEs, so we are forced to bump its version even if the final gpu-operator image does not contain kubectl bits. This change lets us remove that dependency and use client-go functions to manage CRDs. Signed-off-by: Rajath Agasthya <[email protected]>
rajathagasthya
force-pushed
the
remove-kubectl
branch
from
19567dd to
5b00c8f
Compare
cdesiniotis
approved these changes
Oct 28, 2025
Contributor
cdesiniotis
left a comment
cdesiniotis
left a comment
There was a problem hiding this comment.
LGTM. Thanks @rajathagasthya this is a great improvement!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubectl is heavyweight and often has CVEs, so we are forced to bump its version even if the final gpu-operator image does not contain kubectl bits. This change lets us remove that dependency and use client-go functions to manage CRDs.