-
Notifications
You must be signed in to change notification settings - Fork 61
WIP: Add rhel9 base for vGPU-manager containers #486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Close NVIDIA#453 Signed-off-by: Michele Valsecchi <[email protected]>
c5bf10d to
9a950fc
Compare
| @@ -0,0 +1,34 @@ | |||
| FROM nvcr.io/nvidia/cuda:13.0.1-base-ubi9 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately symlinks (from vgpu-manager/rhel8 to vgpu-manager/rhel9) would not cut it, as we pass the subdir, making those files (inside rhel8 unreachable from any other sibling folder).
Let me see if I can come up with a cleaner way, rather than duplicating all the files in vgpu-manager/rhel*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems most directories do indeed have copies of the same files, so I'll leave the duplicates inside vpu-manager/rhel* folders instead of refactoring.
Signed-off-by: Michele Valsecchi <[email protected]>
Signed-off-by: Michele Valsecchi <[email protected]>
|
I tested commit Environment: Outcome: Let me test the refactored version, and also create a VM, to confirm everything work as intended, and I'll remove the |
Close #453
WIP as I have not tested it yet.
I used this RH article as that is the source of truth for RHOCP <> RHCOS matrix.
As per the supported matrix, GPU Operator only support RHOCP 4.14 or later.
I've added extra cases (4.12, 4.13), since some users might be interested in creating drivers for not NVIDIA supported environments, that can still receive updates from Red Hat with Extended Update Support Add-On. If that is not necessary, I can remove the lines covering 4.12, and 4.13.
Since in the GPU Operator docs we do instruct users to export the OS_TAG as per
rhcos4.<x>, I believe theMakefilechanges should not brake any existing automation script.Let me find a lab to test it out, and update accordingly