Update workflow to publish to GHCR on PR tests #459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunAr7112
force-pushed
the
update_workflow_definition
branch
from
4271c54 to
f18f947
Compare
JunAr7112
changed the title
Contributor
Author
|
/ok to test f18f947 |
tariq1890
approved these changes
Oct 6, 2025
JunAr7112
force-pushed
the
update_workflow_definition
branch
from
f18f947 to
c786afd
Compare
JunAr7112
changed the title
JunAr7112
changed the title
JunAr7112
changed the title
cdesiniotis
reviewed
Oct 6, 2025
| - release-* | ||
| push: | ||
| branches: | ||
| - "pull-request/[0-9]+" |
Contributor
There was a problem hiding this comment.
Can we align the entire on block with what we have in other repos? For example https://github.com/NVIDIA/gpu-operator/blob/ee9210bbb64a1c6a01ac67f2d592210c6934a09f/.github/workflows/ci.yaml#L17-L22.
Contributor
There was a problem hiding this comment.
I don't have a strong opinion here, but I lean towards using a config that already works in other projects. I want to make sure the workflow status from the pull-request/[0-9]* branches is reported back to the original PRs.
Contributor
Author
There was a problem hiding this comment.
Ok. I can try that out.
Signed-off-by: agadiyar <[email protected]>
JunAr7112
force-pushed
the
update_workflow_definition
branch
from
c786afd to
4469653
Compare
Contributor
|
/ok to test 4469653 |
Contributor
This appeared to trigger the workflow and the status of the worklfow is viewable from this PR. |
cdesiniotis
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.