-
Notifications
You must be signed in to change notification settings - Fork 62
Restrict e2e runs to 5 instances #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
24f7593 to
11a05a4
Compare
|
@tariq1890 @cdesiniotis PTAL |
|
@shivakunv Please provide more context in the pull request's description |
updated the description |
|
@tariq1890 |
|
@tariq1890 @cdesiniotis PTAL |
11a05a4 to
41f5904
Compare
.github/workflows/precompiled.yaml
Outdated
| matrix: | ||
| kernel_version: ${{ fromJson(needs.collect-e2e-test-matrix.outputs.matrix_values) }} | ||
| exclude: ${{ fromJson(needs.collect-e2e-test-matrix.outputs.exclude_matrix_values) }} | ||
| # no of jobs to run in parallel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove this comment? I think the max-parallel is pretty self-explanatory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed .
tariq1890
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one minor comment
Signed-off-by: Shiva Kumar (SW-CLOUD) <[email protected]>
41f5904 to
6c719f6
Compare
Sometimes ,new kernel releases or enabling full fledged e2e AWS testing , creates too many instances ( >= 12) . This change will restrict AWS instances to batches of 5 . Once a batch of 5 completes , another batch of upto 5 instances will be created to continue running the e2e tests .
This will resolve AWS account instance limit error ( vpcs creation)