holodeck kernel version upgrade #397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
shivakunv
force-pushed
the
holodeck-kernelupgrade
branch
from
5d5a5b4 to
5f86f17
Compare
tariq1890
reviewed
Aug 12, 2025
tariq1890
reviewed
Aug 12, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the holodeck kernel upgrade process by migrating from custom shell scripts to using holodeck's native kernel configuration feature. The change simplifies the workflow by eliminating manual kernel upgrade scripts and leveraging holodeck's built-in capabilities.
- Removes custom kernel upgrade shell scripts (
upgrade-kernel.shandkernel-upgrade-helper.sh) - Updates holodeck configuration files to use native kernel version specification
- Upgrades holodeck action version and Kubernetes versions across test environments
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/scripts/upgrade-kernel.sh | Removes custom kernel upgrade script that handled kernel version parameters |
| tests/scripts/kernel-upgrade-helper.sh | Removes helper script containing kernel upgrade logic with apt commands and reboot handling |
| tests/holodeck_ubuntu24.04.yaml | Adds native kernel version configuration and updates Kubernetes to v1.31.1 |
| tests/holodeck_ubuntu22.04.yaml | Adds native kernel version configuration and updates Kubernetes to v1.31.1 |
| .github/workflows/precompiled.yaml | Updates holodeck action version, adds kernel version setting step, and removes custom kernel upgrade workflow steps |
Comments suppressed due to low confidence (1)
tests/holodeck_ubuntu24.04.yaml:29
- The containerd version 1.7.22 is being removed without replacement. Consider if this version should be updated to maintain consistency with the Kubernetes upgrade to v1.31.1.
name: containerd
5f86f17 to
95cf2f1
Compare
tariq1890
reviewed
Aug 14, 2025
tariq1890
reviewed
Aug 14, 2025
shivakunv
force-pushed
the
holodeck-kernelupgrade
branch
from
95cf2f1 to
404c815
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.