[Ubuntu24.04] Install the driver in a single step #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tariq1890
force-pushed
the
single-step-install
branch
from
ece1c16 to
e6bc8a8
Compare
tariq1890
force-pushed
the
single-step-install
branch
from
e6bc8a8 to
41d0861
Compare
tariq1890
force-pushed
the
single-step-install
branch
from
41d0861 to
2a1f2b2
Compare
tariq1890
commented
Nov 22, 2024
cdesiniotis
reviewed
Nov 22, 2024
ubuntu24.04/nvidia-driver
Outdated
| --x-module-path=/tmp/null \ | ||
| --x-library-path=/tmp/null \ | ||
| --x-sysconfig-path=/tmp/null \ | ||
| -m=${KERNEL_TYPE} \ |
Contributor
There was a problem hiding this comment.
Out of scope for this PR -- looking at this again, it is probably best to not explicitly set this option unless the user sets KERNEL_TYPE (or whatever API is exposed by the operator). Especially now that we are leveraging the nvidia-installer to perform the compilation and installation, we can depend on the defaults the nvidia-installer applies for KERNEL_TYPE -- for example, on newer driver versions it will automatically choose to install the open modules on compatible systems.
tariq1890
force-pushed
the
single-step-install
branch
2 times, most recently
from
b4041f6 to
38a6df2
Compare
cdesiniotis
approved these changes
Nov 25, 2024
tariq1890
force-pushed
the
single-step-install
branch
2 times, most recently
from
6c9414b to
11b3b8e
Compare
cdesiniotis
reviewed
Nov 25, 2024
Signed-off-by: Tariq Ibrahim <[email protected]>
tariq1890
force-pushed
the
single-step-install
branch
from
11b3b8e to
3a0e5fd
Compare
cdesiniotis
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change condenses the two-step driver install into a single step.
Currently, the driver image installs the userspace components and kernel modules separately. This was to allow for signing of the kernel modules with a custom private key and then relinking the signed kernel modules as well as updating the Kernel module should the underlying kernel host be updated.
As none of these workflow apply today, we simplify the driver installation and allow for defining an API in gpu-operator where users can easily pass custom runfile installation arguments
I have tested Driver upgrades and updates (both Open and ClosedRM modules) with these changes and the driver container has been running with no issues