flashdreams.accelerated API v0 - #486
Open
fangjunzhou-nv wants to merge 6 commits into
Open
Conversation
Contributor
Greptile SummaryThe PR introduces reusable accelerated quantization and multi-head-attention primitives, integrates selectable optimized attention backends into OmniDreams, and adds benchmark tooling.
Confidence Score: 5/5The PR appears safe to merge. The previously reported stale derived-weight issue is resolved because optimized attention now registers a post-load hook that rebuilds fused and quantized projections from the loaded canonical parameters, and no blocking failure remains. Important Files Changed
Sequence DiagramsequenceDiagram
participant Network as OmniDreams Network
participant Attention as Optimized Attention
participant Loader as load_state_dict
participant Derived as Derived Projections
participant Forward as Inference
Network->>Attention: Construct canonical Q/K/V projections
Attention->>Derived: Build initial non-persistent projections
Loader->>Attention: Load checkpoint parameters
Attention->>Derived: Post-load hook refreshes fused/quantized weights
Network->>Attention: Move or cast module
Attention->>Derived: _apply refreshes weights on final device/dtype
Forward->>Derived: Execute accelerated projections
Reviews (7): Last reviewed commit: "Add benchmark and plot scripts for flash..." | Re-trigger Greptile |
fangjunzhou-nv
force-pushed
the
dev/fangjun/flashdreams-accelerated
branch
from
August 18, 2026 20:38
3077d4d to
b2685be
Compare
ArielG-NV
reviewed
Aug 18, 2026
ArielG-NV
left a comment
Collaborator
There was a problem hiding this comment.
Question on inclusion of file
fangjunzhou-nv
force-pushed
the
dev/fangjun/flashdreams-accelerated
branch
from
August 20, 2026 20:05
fc4b03f to
f63a088
Compare
fangjunzhou-nv
marked this pull request as draft
August 20, 2026 21:33
fangjunzhou-nv
force-pushed
the
dev/fangjun/flashdreams-accelerated
branch
from
August 22, 2026 00:13
4ad51b5 to
97dfa44
Compare
fangjunzhou-nv
marked this pull request as ready for review
August 22, 2026 00:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add FlashDreams accelerated primitives and integrate them with Omnidreams
Summary
Introduce reusable quantization and optimized multi-head attention primitives under
flashdreams.accelerated, integrate them with Omnidreams, and add reproducible performance benchmarks and plotting tools.1.
flashdreams.accelerated1.1 Quantization toolkit
state_dict, preserving source checkpoint compatibility.1.2 Optimized MHA
BlockKVCacheand preserve caller-managed cache lifecycles.2. Integration: Omnidreams
omnidreams-triton-fa2omnidreams-cuda-cudnnomnidreams-cuda-spargeomnidreams-cuda-sage3fp812.0a3. Benchmark and plot scripts
pytest-benchmarkconfiguration and dependencies.Testing
The change includes CPU, GPU, and manual benchmark coverage. GPU validation requires a supported NVIDIA GPU; the optimized MHA path requires compute capability 9.0 or newer.
Generated benchmark JSON and figures are intentionally not committed.