Unify gamepad input across local-window and WebRTC - #483
Open
wlewNV wants to merge 3 commits into
Open
Conversation
Route native and browser gamepad state through the canonical driver command path so OmniDreams preserves analog control without transport-specific overrides.
wlewNV
marked this pull request as ready for review
August 18, 2026 18:59
Contributor
Greptile SummaryThe PR introduces a canonical, validated gamepad state and routes local SDL and browser WebRTC controls through a shared driving converter.
Confidence Score: 5/5The PR appears safe to merge because the two previously reported control-path failures are resolved and no blocking failure remains. No blocking failure remains. Important Files Changed
Sequence DiagramsequenceDiagram
participant Device as SDL / Browser gamepad
participant Source as Local or WebRTC input source
participant Converter as DrivingInputConverter
participant Provider as OmniDreams provider
participant Integrator as CameraPoseIntegrator
Device->>Source: gamepad_state snapshot
Source->>Converter: timestamped validated event
Converter->>Converter: merge gamepad and keyboard timelines
Converter-->>Provider: canonical driver command + segments
Provider->>Integrator: analog control segments
Integrator-->>Provider: camera poses
Reviews (2): Last reviewed commit: "Fix gamepad arbitration and capability g..." | Re-trigger Greptile |
Preserve mixed keyboard/gamepad timelines, prevent unsupported WebRTC activation, and keep brake and deadzone semantics consistent across transports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gamepad_stateinput and canonicalGamepadToDriverCommandconverter.Validation