Skip to content

Enable nvq++ for more cpp files #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Enable nvq++ for more cpp files #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
47d1bcb
Enable nvq++ for more cpp files
bmhowe23 Dec 4, 2024
0be1bee
Merge branch 'main' into pr-use-nvqpp-more
bmhowe23 May 12, 2025
1d6a502
Add debug
bmhowe23 May 12, 2025
239d3a0
Compilation issue
bmhowe23 May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/actions/build-lib/build_qec.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
#!/bin/sh

echo cmake -S libs/qec -B "$1" -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_COMPILER=gcc-11 -DCMAKE_CXX_COMPILER=g++-11 -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache -DCUDAQ_DIR=/cudaq-install/lib/cmake/cudaq/ -DCUDAQX_INCLUDE_TESTS=ON -DCUDAQX_BINDINGS_PYTHON=ON -DCMAKE_INSTALL_PREFIX=$HOME/.cudaqx

cmake -S libs/qec -B "$1" \
-DCMAKE_BUILD_TYPE=Release \
-DCMAKE_C_COMPILER=gcc-11 \
Expand Down
2 changes: 1 addition & 1 deletion libs/core/include/cuda-qx/core/tensor_impl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ class tensor_impl : public extension_point<tensor_impl<Scalar>, const Scalar *,
scalar_type *scalar_data = new scalar_type[size]();
auto result = iter->second(scalar_data, {num_rows, num_cols});
for (size_t r = 0; r < num_rows; r++) {
Scalar __restrict__ *resultRow = &result->at({r, 0});
Scalar *__restrict__ resultRow = &result->at({r, 0});
for (size_t c = 0; c < num_cols; c++) {
resultRow[c] = data[r][c] - '0';
}
Expand Down
2 changes: 0 additions & 2 deletions libs/qec/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,6 @@ endif()
# ==============================================================================

if (CUDAQX_QEC_STANDALONE_BUILD)
# FIXME for now, we only use library mode
set(CUDAQ_LIBRARY_MODE ON)
find_package(CUDAQ REQUIRED)

# FIXME
Expand Down
2 changes: 0 additions & 2 deletions libs/solvers/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,6 @@ FetchContent_Declare(
FetchContent_MakeAvailable(cppitertools json)

if (CUDAQX_SOLVERS_STANDALONE_BUILD)
# FIXME for now, we only use library mode
set(CUDAQ_LIBRARY_MODE ON)
find_package(CUDAQ REQUIRED)

# FIXME
Expand Down
Loading