Update Python bridge to properly handled nested expressions and other fixes

lib/Frontend/nvqpp/ConvertStmt.cpp

@@ -359,6 +359,9 @@ bool QuakeBridgeVisitor::VisitReturnStmt(clang::ReturnStmt *x) {
       if (!cudaq::cc::isDynamicType(eleTy))
         tySize = irb.getByteSizeOfType(loc, eleTy);
       if (!tySize) {
+        // TODO: we need to recursively create copies of all
+        // dynamic memory used within the type. See the
+        // implementation of `visit_Return` in the Python bride.
         TODO_x(toLocation(x), x, mangler, "unhandled vector element type");
         return false;
       }

lib/Optimizer/CodeGen/CCToLLVM.cpp

@@ -524,8 +524,7 @@ class SizeOfOpPattern : public ConvertOpToLLVMPattern<cudaq::cc::SizeOfOp> {
                   ConversionPatternRewriter &rewriter) const override {
     auto inputTy = sizeOfOp.getInputType();
     auto resultTy = sizeOfOp.getType();
-    if (quake::isQuakeType(inputTy) || cudaq::cc::isDynamicType(inputTy)) {
-      // Types that cannot be reified produce the poison op.
+    if (quake::isQuakeType(inputTy)) {
       rewriter.replaceOpWithNewOp<cudaq::cc::PoisonOp>(sizeOfOp, resultTy);
       return success();
     }

lib/Optimizer/Transforms/GenKernelExecution.cpp

@@ -1054,6 +1054,32 @@ class GenerateKernelExecution
           thunk = genThunkFunction(loc, builder, classNameStr, structTy, funcTy,
                                    funcOp);
 
+          // The `argsCreator` function doesn't properly deal with structs
+          // that contain dynamic types. Since we want to revise that in a 
+          // future version, I am opting to simply give a comprehensive enough
+          // error here rather than fixing that. If we don't fail here, the
+          // invocation of the `argsCreator` as it is will segfault.
+          auto checkDynamicStructMember = [&module](llvm::ArrayRef<mlir::Type> tys) {
+            mlir::LogicalResult res = success();
+            for (auto ty : tys) {
+              if (cudaq::cc::isDynamicType(ty)) {
+                if (auto strTy = dyn_cast<cudaq::cc::StructType>(ty)) {
+                  for (auto memTy : strTy.getMembers()) {
+                    if (cudaq::cc::isDynamicType(memTy))
+                      res = module.emitError("dynamically sized element types for function arguments or returns are not supported");
+                      return res;
+                  }
+                }
+              }
+            }
+            return res;
+          };
+
+          if (failed(checkDynamicStructMember(funcTy.getInputs().drop_front(startingArgIdx))))
+            return signalPassFailure();
+          if (failed(checkDynamicStructMember(funcTy.getResults())))
+            return signalPassFailure();
+
           // Generate the argsCreator function used by synthesis.
           if (startingArgIdx == 0) {
             argsCreatorFunc = genKernelArgsCreatorFunction(

python/cudaq/kernel/analysis.py

@@ -110,9 +110,11 @@ def visit_Call(self, node):
                              'attr') and node.func.attr in globalAstRegistry:
                     self.depKernels[node.func.attr] = globalAstRegistry[
                         node.func.attr]
-                elif node.func.value.id == 'cudaq' and node.func.attr in [
-                        'control', 'adjoint'
-                ] and node.args[0].id in globalAstRegistry:
+                elif isinstance(node.func.value, ast.Name) and \
+                    node.func.value.id == 'cudaq' and \
+                    node.func.attr in ['control', 'adjoint'] and \
+                    isinstance(node.args[0], ast.Name) and \
+                    node.args[0].id in globalAstRegistry:
                     self.depKernels[node.args[0].id] = globalAstRegistry[
                         node.args[0].id]