Skip to content

Conversation

@radumarg
Copy link
Contributor

@radumarg radumarg commented Oct 21, 2025

Summary: adds memory to support shotwise output

Details and comments:

  • need to get shotwise endpoint only when requested but default is to enable memory
  • do not attempt shotwise for ideal simulations

Fixes issue #3572.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 21, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@radumarg radumarg marked this pull request as ready for review October 29, 2025 17:21
@radumarg radumarg changed the title Partial implementation. Add support for shot-wise output in IonQ Oct 29, 2025
I, Radu Marginean <[email protected]>, hereby add my Signed-off-by to this commit: 7e8774d
I, Radu Marginean <[email protected]>, hereby add my Signed-off-by to this commit: 671dd89

Signed-off-by: Radu Marginean <[email protected]>
@radumarg radumarg changed the title Add support for shot-wise output in IonQ Add support for shot-wise output fro IonQ jobs Oct 29, 2025
@radumarg radumarg changed the title Add support for shot-wise output fro IonQ jobs Add support for shot-wise output for IonQ jobs Oct 29, 2025
@sacpis
Copy link
Collaborator

sacpis commented Nov 12, 2025

/ok to test 5715afb

Command Bot: Processing...

github-actions bot pushed a commit that referenced this pull request Nov 12, 2025
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Copy link
Collaborator

sacpis commented Nov 12, 2025

/ok to test c6fe0df

Command Bot: Processing...

github-actions bot pushed a commit that referenced this pull request Nov 12, 2025
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.


def test_shot_wise_output_with_memory_and_noise_model():

cudaq.set_target("ionq", url="http://localhost:{}".format(port), noise='forte-enterprise-1', memory=True)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am missing the corresponding change to expose the memory argument for C++ users (the ionq.yml file defines the command line options for C++).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants