Add clang CI test #743
Merged
Add clang CI test #743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/ok to test f27cfc9 |
PointKernel
added
topic: CI
Collaborator
|
/ok to test ad63e43 |
…ng devcontainer configs - Remove skipped condition from ci-success job to allow intentionally skipped test jobs - Add missing devcontainer configs for cuda12.0-gcc11 and cuda12.8-llvm16 to match matrix.yml
- Add build volume management for better performance - Include additional VSCode extensions (clang-format, nsight, cmake-tools) - Enhanced editor settings with format-on-save and better clangd config - Make GPU requirement optional for better compatibility - Add build infix environment variable for consistency
- Add missing newline to cuda12.0-gcc11/devcontainer.json - Standardize cuda12.8-llvm16/devcontainer.json to match base template - Remove custom enhancements to follow project standards - Generated using .devcontainer/make_devcontainers.sh
sleeepyjack
reviewed
Jul 24, 2025
Collaborator
sleeepyjack
left a comment
sleeepyjack
left a comment
There was a problem hiding this comment.
It seems GH actions is encountering a syntax error: https://github.com/NVIDIA/cuCollections/actions/runs/16486736912/workflow
Comment on lines
+236
to
+237
| [[fallthrough]]; | ||
| case 0: break; |
Collaborator
There was a problem hiding this comment.
This should also go into the CCCL port
Member
Author
|
/ok to test 3e6e64c |
PointKernel
commented
Jul 24, 2025
sleeepyjack
approved these changes
Jul 24, 2025
Collaborator
sleeepyjack
left a comment
sleeepyjack
left a comment
There was a problem hiding this comment.
Thanks for going through this CI struggle. Nice work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #744
Fixes #128
This PR adds a CI task to test building with Clang as the host compiler and addresses associated build warnings and errors.