Add a type and operation enum to CUB #6780
Merged
+131
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernhardmgruber
force-pushed
the
type_enum
branch
from
15075e8 to
cfb1dde
Compare
And use it in the scan tunings to test it.
bernhardmgruber
force-pushed
the
type_enum
branch
from
cfb1dde to
8d9e714
Compare
This comment has been minimized.
This comment has been minimized.
fbusato
reviewed
Nov 25, 2025
|
|
||
| template <class ValueT, class AccumT, class OffsetT> | ||
| struct sm75_tuning<ValueT, AccumT, OffsetT, op_type::plus, primitive_accum::yes, offset_size::_8, value_size::_4> | ||
| struct sm75_tuning<ValueT, AccumT, OffsetT, op_kind_t::plus, primitive_accum::yes, offset_size::_8, value_size::_4> |
Contributor
There was a problem hiding this comment.
question. Most of the code is not in the detail namespace. Is this something that we can change without affecting users?
Contributor
Author
There was a problem hiding this comment.
The changes entities are in the namespace cub::detail::scan. We should be fine.
fbusato
approved these changes
Nov 25, 2025
Contributor
🥳 CI Workflow Results🟩 Finished in 8h 43m: Pass: 100%/93 | Total: 5d 01h | Max: 4h 55m | Hits: 39%/95086See results here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And use it in the scan tunings to test it.
cub.test.device.scan.lid_0.types_0on sm120