-
Notifications
You must be signed in to change notification settings - Fork 204
draft: Add per block MSE for NVFP4 and INT4 #613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Fridah-nv <[email protected]>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #613 +/- ##
==========================================
+ Coverage 74.57% 74.65% +0.08%
==========================================
Files 183 183
Lines 18412 18546 +134
==========================================
+ Hits 13730 13845 +115
- Misses 4682 4701 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
|
|
||
| @triton.jit | ||
| def blockwise_fp4_fake_quant_kernel( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| def blockwise_fp4_fake_quant_kernel( | |
| def static_blockwise_fp4_fake_quant_kernel( |
| disable_calib(quantizer), | ||
| enable_fake_quant(quantizer), | ||
| ): | ||
| quantizer._keep_shape = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line 233:
if is_nvfp4_static: # static per-block
amax = scaled_e4m3_impl(amax, amax.amax()) # fP8 quantization
What does this PR do?
Type of change: ?
Overview: ?
Usage
# Add a code snippet demonstrating how to use thisTesting
Before your PR is "Ready for review"
Additional Information