Skip to content

Conversation

@meenchen
Copy link
Contributor

@meenchen meenchen commented Nov 6, 2025

What does this PR do?

Type of change: bug fix

Overview: instead of using amax, we should compute block_scale on the fly

Usage

# Add a code snippet demonstrating how to use this

Testing

Before your PR is "Ready for review"

  • Make sure you read and follow Contributor guidelines and your commits are signed.
  • Is this change backward compatible?: Yes/No
  • Did you write any new necessary tests?: Yes/No
  • Did you add or update any necessary documentation?: Yes/No
  • Did you update Changelog?: Yes/No

Additional Information

Signed-off-by: weimingc <[email protected]>
@meenchen meenchen requested a review from a team as a code owner November 6, 2025 22:10
@meenchen meenchen requested a review from cjluo-nv November 6, 2025 22:10
@meenchen meenchen self-assigned this Nov 6, 2025
@meenchen meenchen requested a review from realAsma November 6, 2025 22:11
Signed-off-by: weimingc <[email protected]>
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.64%. Comparing base (32d168c) to head (86546cd).
⚠️ Report is 121 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #522      +/-   ##
==========================================
+ Coverage   73.38%   74.64%   +1.26%     
==========================================
  Files         180      183       +3     
  Lines       17934    18547     +613     
==========================================
+ Hits        13160    13844     +684     
+ Misses       4774     4703      -71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@meenchen meenchen requested a review from cjluo-nv December 2, 2025 20:19
Signed-off-by: weimingc <[email protected]>
Signed-off-by: weimingc <[email protected]>
@meenchen meenchen enabled auto-merge (squash) December 2, 2025 22:33
@meenchen meenchen merged commit 422c58b into main Dec 3, 2025
27 checks passed
@meenchen meenchen deleted the weimingc/fix_fp8_blcok_realquant branch December 3, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants