Skip to content

Conversation

@mlefeb01
Copy link
Collaborator

@mlefeb01 mlefeb01 commented Nov 22, 2025

…thers-1 to SLURM

Summary by CodeRabbit

  • Chores
    • Updated test infrastructure for DGX H100 PyTorch configurations to utilize OCI-based execution environments, replacing previous test setup configurations with improved cloud-based alternatives for enhanced scalability and resource management.

✏️ Tip: You can customize this high-level summary in your review settings.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@mlefeb01 mlefeb01 self-assigned this Nov 22, 2025
@mlefeb01 mlefeb01 requested review from a team as code owners November 22, 2025 03:05
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 22, 2025

📝 Walkthrough

Walkthrough

Test configuration migration in the Jenkins pipeline groovy script: two DGX H100 PyTorch test configurations (DeepSeek and Others) were removed from the standard x86TestConfigs mapping and replaced with OCI-based variants under x86SlurmTestConfigs, effectively routing these tests to OCI-based Slurm execution infrastructure.

Changes

Cohort / File(s) Summary
Test Configuration Migration
jenkins/L0_Test.groovy
Removed 2 DGX H100 PyTorch test entries from x86TestConfigs (DeepSeek-1, Others-1). Added 2 corresponding OCI-based variants to x86SlurmTestConfigs mapping to dgx-h100-x4-oci and dgx-h100-x2-oci images.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify that the removed entries from x86TestConfigs match the added entries in x86SlurmTestConfigs in terms of test identifiers
  • Confirm OCI image references (dgx-h100-x4-oci, dgx-h100-x2-oci) are correct and available
  • Ensure no other code sections reference the removed x86TestConfigs entries

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is largely empty with only template placeholders and no actual content explaining the purpose, rationale, or test coverage for the changes. Provide a detailed Description section explaining why these tests are being moved to SLURM, add relevant Test Coverage information, and complete the PR Checklist to confirm code review requirements are met.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically identifies the main change: moving two DGX_H100 PyTorch test configurations to SLURM, matching the actual modifications in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fefa02f and adc6fea.

📒 Files selected for processing (1)
  • jenkins/L0_Test.groovy (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: pengbowang-nv
Repo: NVIDIA/TensorRT-LLM PR: 7192
File: tests/integration/test_lists/test-db/l0_dgx_b200.yml:56-72
Timestamp: 2025-08-26T09:49:04.956Z
Learning: In TensorRT-LLM test configuration files, the test scheduling system handles wildcard matching with special rules that prevent duplicate test execution even when the same tests appear in multiple yaml files with overlapping GPU wildcards (e.g., "*b200*" and "*gb200*").
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (1)
jenkins/L0_Test.groovy (1)

2740-2741: Migration verified and complete.

Both verification checks have been successfully confirmed:

  1. Removal from x86TestConfigs: ✓ Neither DGX_H100-4_GPUs-PyTorch-DeepSeek-1 nor DGX_H100-2_GPUs-PyTorch-Others-1 appear in the x86TestConfigs section (lines 2630-2722), confirming they have been properly migrated away from the Kubernetes infrastructure.

  2. OCI platform identifiers validated: ✓ The platform identifiers dgx-h100-x4-oci and dgx-h100-x2-oci are already in active use in existing SLURM configurations (lines 2742-2744), confirming they are properly configured in SlurmConfig.partitionConfig.

The migration from Kubernetes to SLURM infrastructure is clean with no duplicate test execution risk.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mlefeb01
Copy link
Collaborator Author

/bot run --disable-fail-fast --stage-list "DGX_H100-4_GPUs-CPP-1,DGX_H100-4_GPUs-PyTorch-DeepSeek-1,DGX_H100-2_GPUs-PyTorch-Others-1,DGX_H100-2_GPUs-PyTorch-Ray-1,DGX_H100-4_GPUs-PyTorch-GptOss-1,DGX_H100-4_GPUs-PyTorch-Others-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25408 [ run ] triggered by Bot. Commit: adc6fea

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25408 [ run ] completed with state SUCCESS. Commit: adc6fea
/LLM/main/L0_MergeRequest_PR pipeline #19224 (Partly Tested) completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@mlefeb01
Copy link
Collaborator Author

/bot run --disable-fail-fast --stage-list "DGX_H100-4_GPUs-CPP-1,DGX_H100-4_GPUs-PyTorch-DeepSeek-1,DGX_H100-2_GPUs-PyTorch-Others-1,DGX_H100-2_GPUs-PyTorch-Ray-1,DGX_H100-4_GPUs-PyTorch-GptOss-1,DGX_H100-4_GPUs-PyTorch-Others-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25489 [ run ] triggered by Bot. Commit: 28797d3

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25489 [ run ] completed with state SUCCESS. Commit: 28797d3
/LLM/main/L0_MergeRequest_PR pipeline #19300 (Partly Tested) completed with status: 'FAILURE'

@mlefeb01
Copy link
Collaborator Author

Closing in favor of #9395

@mlefeb01 mlefeb01 closed this Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants