[None][fix] Enabled simultaneous support for low-precision combine and MTP. #9091
Conversation
|
/bot run |
📝 WalkthroughWalkthroughA new method Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tensorrt_llm/_torch/modules/fused_moe/fused_moe_wide_ep.py (1)
443-448: Consider adding an assertion and docstring for consistency.The method correctly encapsulates the low-precision combine support logic. However, for consistency with the properties it depends on (
has_fp8_qdq,has_nvfp4,has_w4afp8), consider:
- Adding an assertion that weights have been created
- Adding a docstring to document the method's purpose and conditions
Apply this diff:
def is_low_precision_combine_supported(self): + """ + Check if low-precision combine is supported for the current configuration. + + Returns: + bool: True if low-precision combine is supported, False otherwise. + """ + assert self._weights_created if not self.use_low_precision_combine: return False if self.alltoall_method_type == AlltoallMethodType.DeepEPLowLatency: return self.has_fp8_qdq or self.has_nvfp4 or self.has_w4afp8 return False
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
tensorrt_llm/_torch/modules/fused_moe/fused_moe_wide_ep.py(2 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Use only spaces, no tabs; indent with 4 spaces.
Files:
tensorrt_llm/_torch/modules/fused_moe/fused_moe_wide_ep.py
**/*.py
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.
Files:
tensorrt_llm/_torch/modules/fused_moe/fused_moe_wide_ep.py
**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).
Files:
tensorrt_llm/_torch/modules/fused_moe/fused_moe_wide_ep.py
🧠 Learnings (1)
📚 Learning: 2025-08-21T02:39:12.009Z
Learnt from: djns99
Repo: NVIDIA/TensorRT-LLM PR: 7104
File: cpp/tensorrt_llm/kernels/cutlass_kernels/moe_gemm/moe_kernels.cu:1475-1480
Timestamp: 2025-08-21T02:39:12.009Z
Learning: The min latency mode functionality in TensorRT-LLM MOE kernels (cpp/tensorrt_llm/kernels/cutlass_kernels/moe_gemm/moe_kernels.cu) is deprecated and no longer being maintained/updated, as confirmed by djns99. Bug reports and optimization suggestions for the computeStridesTmaWarpSpecializedLowLatencyKernel and related min latency code paths should be deprioritized.
Applied to files:
tensorrt_llm/_torch/modules/fused_moe/fused_moe_wide_ep.py
🧬 Code graph analysis (1)
tensorrt_llm/_torch/modules/fused_moe/fused_moe_wide_ep.py (2)
tensorrt_llm/_torch/modules/fused_moe/interface.py (3)
AlltoallMethodType(26-34)has_fp8_qdq(301-304)has_nvfp4(313-316)tensorrt_llm/_torch/modules/fused_moe/fused_moe_cutlass.py (1)
has_w4afp8(214-217)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (1)
tensorrt_llm/_torch/modules/fused_moe/fused_moe_wide_ep.py (1)
751-751: LGTM! Improved condition check.The replacement of the direct property check with
is_low_precision_combine_supported()correctly ensures that low-precision combine is only used when both the feature flag is enabled AND the appropriate quantization configuration is present. This prevents potential runtime errors when quantization is not configured properly.
|
PR_Github #24286 [ run ] triggered by Bot. Commit: |
|
PR_Github #24286 [ run ] completed with state |
yilin-void
force-pushed
the
fix/low_precision_combine_mtp
branch
from
d1a8dfc to
67d64fb
Compare
|
/bot run |
|
PR_Github #24422 [ run ] triggered by Bot. Commit: |
|
PR_Github #24422 [ run ] completed with state |
yilin-void
force-pushed
the
fix/low_precision_combine_mtp
branch
from
67d64fb to
f13ed1a
Compare
|
/bot run |
|
PR_Github #24572 [ run ] triggered by Bot. Commit: |
|
PR_Github #24572 [ run ] completed with state |
yilin-void
force-pushed
the
fix/low_precision_combine_mtp
branch
from
f13ed1a to
5deef0f
Compare
|
/bot run |
|
PR_Github #24729 [ run ] triggered by Bot. Commit: |
|
PR_Github #24729 [ run ] completed with state |
yilin-void
force-pushed
the
fix/low_precision_combine_mtp
branch
from
5deef0f to
4ec3da5
Compare
|
/bot run |
|
PR_Github #24870 [ run ] triggered by Bot. Commit: |
|
PR_Github #24870 [ run ] completed with state |
yilin-void
force-pushed
the
fix/low_precision_combine_mtp
branch
from
4ec3da5 to
44153e2
Compare
|
/bot run |
yilin-void
force-pushed
the
fix/low_precision_combine_mtp
branch
from
44153e2 to
6f6fb6e
Compare
|
/bot run |
|
PR_Github #25122 [ run ] triggered by Bot. Commit: |
|
PR_Github #25122 [ run ] completed with state |
yilin-void
force-pushed
the
fix/low_precision_combine_mtp
branch
from
6f6fb6e to
d5ad4ce
Compare
|
/bot run |
|
PR_Github #25162 [ run ] triggered by Bot. Commit: |
|
PR_Github #25162 [ run ] completed with state |
yilin-void
force-pushed
the
fix/low_precision_combine_mtp
branch
from
d5ad4ce to
a19ef05
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #25188 [ run ] triggered by Bot. Commit: |
|
PR_Github #25188 [ run ] completed with state |
|
/bot run |
|
PR_Github #25287 [ run ] triggered by Bot. Commit: |
|
PR_Github #25287 [ run ] completed with state |
yilin-void
force-pushed
the
fix/low_precision_combine_mtp
branch
from
a19ef05 to
f895c44
Compare
|
/bot run |
|
PR_Github #25305 [ run ] triggered by Bot. Commit: |
|
PR_Github #25305 [ run ] completed with state |
Signed-off-by: Yilin Zhang <[email protected]>
yilin-void
force-pushed
the
fix/low_precision_combine_mtp
branch
from
f895c44 to
e5e3296
Compare
|
/bot run |
|
PR_Github #25350 [ run ] triggered by Bot. Commit: |
2 participants
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.