Skip to content

Conversation

@pcastonguay
Copy link
Collaborator

fix: Fix spec decode triton test

Description

There is a prompt in the spec decoding Triton tests that seem to produce one of two outputs, causing this test to sometimes fail. When I run locally, the test fails roughly 20% of the time. So I'm removing the problematic prompt from the dataset.

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@pcastonguay
Copy link
Collaborator Author

/bot run --post-merge

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7232 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7232 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5237 completed with status: 'FAILURE'

@pcastonguay pcastonguay force-pushed the fix_spec_decode_triton_tests branch from a266ddb to 830809d Compare June 2, 2025 23:34
@pcastonguay
Copy link
Collaborator Author

/bot run --post-merge --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7250 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7250 [ run ] completed with state ABORTED

@pcastonguay
Copy link
Collaborator Author

/bot run --stage-list "A100X-Triton-Python-[Post-Merge]-1, A100X-Triton-Python-[Post-Merge]-2"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7527 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7527 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5459 (Partly Tested) completed with status: 'SUCCESS'

@pcastonguay pcastonguay force-pushed the fix_spec_decode_triton_tests branch from 830809d to dc2987e Compare June 4, 2025 17:51
@pcastonguay pcastonguay requested a review from Tabrizian June 4, 2025 17:52
@pcastonguay
Copy link
Collaborator Author

/bot run --stage-list "A100X-Triton-Python-[Post-Merge]-1, A100X-Triton-Python-[Post-Merge]-2"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7555 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7555 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5483 (Partly Tested) completed with status: 'SUCCESS'

@pcastonguay pcastonguay force-pushed the fix_spec_decode_triton_tests branch from dc2987e to 596ac43 Compare June 5, 2025 12:59
@pcastonguay
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7736 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7736 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5607 completed with status: 'FAILURE'

@pcastonguay pcastonguay force-pushed the fix_spec_decode_triton_tests branch from 596ac43 to 32bb7d8 Compare June 5, 2025 16:47
@pcastonguay
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7780 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7780 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #5634 completed with status: 'FAILURE'

@pcastonguay pcastonguay force-pushed the fix_spec_decode_triton_tests branch from 32bb7d8 to e388231 Compare June 6, 2025 15:15
@pcastonguay
Copy link
Collaborator Author

/bot run --stage-list "A100X-Triton-Python-[Post-Merge]-1, A100X-Triton-Python-[Post-Merge]-2"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7924 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7924 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #5729 (Partly Tested) completed with status: 'FAILURE'

Signed-off-by: Patrice Castonguay <[email protected]>
@pcastonguay pcastonguay force-pushed the fix_spec_decode_triton_tests branch from e388231 to 87e956e Compare June 8, 2025 22:39
@pcastonguay
Copy link
Collaborator Author

/bot run --stage-list "A100X-Triton-Python-[Post-Merge]-1, A100X-Triton-Python-[Post-Merge]-2"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8047 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8047 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5833 (Partly Tested) completed with status: 'SUCCESS'

@pcastonguay
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8058 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8058 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5842 completed with status: 'SUCCESS'

@pcastonguay pcastonguay merged commit 5b84fd9 into NVIDIA:main Jun 9, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants