[None][ci] Move more test stages to use OCI machines #9395
Conversation
|
/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-1, GB200-8_GPUs-2_Nodes-PyTorch-2, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-1, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-2, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-3, GB200-4_GPUs-PyTorch-1, GB200-4_GPUs-PyTorch-Post-Merge-1, DGX_H100-2_GPUs-PyTorch-Others-1, DGX_H100-4_GPUs-PyTorch-DeepSeek-1" --disable-fail-fast |
📝 WalkthroughWalkthroughThe file makes targeted adjustments to Jenkins test orchestration: relaxing file-existence checks in cleanup routines, throttling Slurm release calls, removing duplicate environment exports, and restructuring x86/GB200 test configurations to use OCI-based hostnames and explicit mappings rather than programmatic generation. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
jenkins/L0_Test.groovy (2)
416-425: Relaxedslurm_job_idfetch is fine; optionally hide missing-file noiseUsing
cat ${jobWorkspace}/slurm_job_id.txt || truekeeps behavior non-fatal when the file is absent and simplifies the check. It may, however, emitNo such file or directoryon stderr in the Jenkins logs when the file is missing. If you want quieter logs, consider:script: Utils.sshUserCmd( remote, "\"cat ${jobWorkspace}/slurm_job_id.txt 2>/dev/null || true\"" )This preserves current semantics while suppressing spurious errors.
602-613: Throttlingscontrol releaselooks good; consider skipping when job ID is emptyReleasing only every 3 iterations (
counter % 3 == 0) will substantially reducescontrol releasetraffic while still running often enough (every 30 minutes) within the 15‑hour window.To avoid pointless calls when submission fails and
slurmJobIDis null/empty, you could guard the release:if (slurmJobID && counter % 3 == 0) { Utils.exec(pipeline, script: Utils.sshUserCmd(remote, "\"scontrol release ${slurmJobID} || true\""), numRetries: 3) }Not required, but it trims no-op SSH calls and log noise.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
jenkins/L0_Test.groovy(4 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-08-26T09:49:04.956Z
Learnt from: pengbowang-nv
Repo: NVIDIA/TensorRT-LLM PR: 7192
File: tests/integration/test_lists/test-db/l0_dgx_b200.yml:56-72
Timestamp: 2025-08-26T09:49:04.956Z
Learning: In TensorRT-LLM test configuration files, the test scheduling system handles wildcard matching with special rules that prevent duplicate test execution even when the same tests appear in multiple yaml files with overlapping GPU wildcards (e.g., "*b200*" and "*gb200*").
Applied to files:
jenkins/L0_Test.groovy
📚 Learning: 2025-09-09T09:40:45.658Z
Learnt from: fredricz-20070104
Repo: NVIDIA/TensorRT-LLM PR: 7645
File: tests/integration/test_lists/qa/llm_function_core.txt:648-648
Timestamp: 2025-09-09T09:40:45.658Z
Learning: In TensorRT-LLM test lists, it's common and intentional for the same test to appear in multiple test list files when they serve different purposes (e.g., llm_function_core.txt for comprehensive core functionality testing and llm_function_core_sanity.txt for quick sanity checks). This duplication allows tests to be run in different testing contexts.
Applied to files:
jenkins/L0_Test.groovy
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (3)
jenkins/L0_Test.groovy (3)
2741-2747: New DGX H100 OCI Slurm configs look consistent; verify SlurmConfig wiringThe added entries:
"DGX_H100-2_GPUs-PyTorch-Others-1": ["dgx-h100-x2-oci", "l0_dgx_h100", 1, 1, 2], "DGX_H100-2_GPUs-PyTorch-Ray-1": ["dgx-h100-x2-oci", "l0_dgx_h100", 1, 1, 2], "DGX_H100-4_GPUs-PyTorch-DeepSeek-1": ["dgx-h100-x4-oci", "l0_dgx_h100", 1, 1, 4],match the naming conventions (GPU count in the stage name, backend
-PyTorch-, DeepSeek/Ray/Others tags) and the value layout used elsewhere ([platform, yaml, splitId, splits, gpuCount, …]). They will correctly route throughrunLLMTestlistOnSlurmwith 2 or 4 GPUs on a single node.Please double-check:
SlurmConfig.partitionConfig/clusterConfigdefinedgx-h100-x2-ocianddgx-h100-x4-oci.tests/integration/test_lists/test-db/l0_dgx_h100.ymlcovers the desired subsets for these new stage names.
2781-2786: GB200 x4 SBSA Slurm configs are aligned; confirm YAML & partition definitionsThe new SBSA Slurm entries:
"GB200-4_GPUs-PyTorch-1": ["gb200-x4-oci", "l0_gb200_multi_gpus", 1, 1, 4], "GB200-4_GPUs-PyTorch-Post-Merge-1": ["gb200-x4-oci", "l0_gb200_multi_gpus", 1, 1, 4], // "GB300-4_GPUs-PyTorch-Post-Merge-1": ["gb300-x4", "l0_gb300_multi_gpus", 1, 1, 4],fit the existing pattern (stage name encodes GPU count and post-merge status; value array matches
[platform, yaml, splitId, splits, gpuCount]). For AArch64, these will be picked up in the SBSA Slurm branch and treated as multi‑GPU jobs via the"4_GPUs"marker.Given prior behavior with overlapping GB200 lists and wildcards, it’s expected that
l0_gb200_multi_gpusmay overlap with other GB200 YAMLs, and the scheduler should still dedupe execution. Based on learnings, this duplication is acceptable at the test-db layer.Please verify:
gb200-x4-ociis configured inSlurmConfig.partitionConfig.l0_gb200_multi_gpus.ymlexists in the test-db and contains the intended GB200 SBSA cases.
2789-2797: Explicit GB200 8‑GPU 2‑node SBSA configs look correct; ensure Slurm + test-db plumbingThe new multi-node SBSA mapping:
multiNodesSBSAConfigs = [ "GB200-8_GPUs-2_Nodes-PyTorch-1": ["gb200-oci-trtllm", "l0_gb200_multi_nodes", 1, 2, 8, 2], "GB200-8_GPUs-2_Nodes-PyTorch-2": ["gb200-oci-trtllm", "l0_gb200_multi_nodes", 2, 2, 8, 2], "GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-1": ["gb200-oci-trtllm", "l0_gb200_multi_nodes", 1, 3, 8, 2], "GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-2": ["gb200-oci-trtllm", "l0_gb200_multi_nodes", 2, 3, 8, 2], "GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-3": ["gb200-oci-trtllm", "l0_gb200_multi_nodes", 3, 3, 8, 2], ]is consistent with:
parseMultiNodeTaskConfigFromStageName, which expects<GPU>-<N>_GPUs-<M>_Nodes-…and will extractgpu=GB200andsystem_gpu_count=8.getNodeArgs(nodeCount, gpuCount), yielding 8 GPUs across 2 nodes (4 per node) as expected.These will be correctly picked up in the SBSA multi-node Slurm branch (AArch64) as multi-GPU, multi-node jobs.
Please validate:
gb200-oci-trtllmexists inSlurmConfig.partitionConfigand points at the intended OCI GB200 cluster.l0_gb200_multi_nodes.ymlexists and contains the test-db definitions aligned with the new multi-node scenarios.
|
PR_Github #25513 [ run ] triggered by Bot. Commit: |
|
/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-1, GB200-8_GPUs-2_Nodes-PyTorch-2, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-1, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-2, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-3, GB200-4_GPUs-PyTorch-1, GB200-4_GPUs-PyTorch-Post-Merge-1, DGX_H100-2_GPUs-PyTorch-Others-1, DGX_H100-4_GPUs-PyTorch-DeepSeek-1" --disable-fail-fast |
|
PR_Github #25548 [ run ] triggered by Bot. Commit: |
|
PR_Github #25513 [ run ] completed with state |
|
PR_Github #25548 [ run ] completed with state |
|
/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-1, GB200-8_GPUs-2_Nodes-PyTorch-2, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-1, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-2, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-3, GB200-4_GPUs-PyTorch-1, GB200-4_GPUs-PyTorch-Post-Merge-1, DGX_H100-2_GPUs-PyTorch-Others-1, DGX_H100-4_GPUs-PyTorch-DeepSeek-1" --disable-fail-fast |
|
PR_Github #25572 [ run ] triggered by Bot. Commit: |
|
/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-1, GB200-8_GPUs-2_Nodes-PyTorch-2, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-1, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-2, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-3, GB200-4_GPUs-PyTorch-1, GB200-4_GPUs-PyTorch-Post-Merge-1, DGX_H100-2_GPUs-PyTorch-Others-1, DGX_H100-4_GPUs-PyTorch-DeepSeek-1" --disable-fail-fast |
|
PR_Github #25577 [ run ] triggered by Bot. Commit: |
|
PR_Github #25572 [ run ] completed with state |
|
/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-1, GB200-8_GPUs-2_Nodes-PyTorch-2, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-1, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-2, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-3, GB200-4_GPUs-PyTorch-1, GB200-4_GPUs-PyTorch-Post-Merge-1, DGX_H100-2_GPUs-PyTorch-Others-1, DGX_H100-4_GPUs-PyTorch-DeepSeek-1" --disable-fail-fast |
|
PR_Github #25594 [ run ] triggered by Bot. Commit: |
|
PR_Github #25577 [ run ] completed with state |
Signed-off-by: Yanchao Lu <[email protected]>
|
/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-1, GB200-8_GPUs-2_Nodes-PyTorch-2, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-1, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-2, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-3, GB200-4_GPUs-PyTorch-1, GB200-4_GPUs-PyTorch-Post-Merge-1, DGX_H100-2_GPUs-PyTorch-Others-1, DGX_H100-4_GPUs-PyTorch-DeepSeek-1" --disable-fail-fast |
|
PR_Github #25595 [ run ] triggered by Bot. Commit: |
|
PR_Github #25594 [ run ] completed with state |
|
/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-1, GB200-8_GPUs-2_Nodes-PyTorch-2, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-1, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-2, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-3, GB200-4_GPUs-PyTorch-1, GB200-4_GPUs-PyTorch-Post-Merge-1, DGX_H100-2_GPUs-PyTorch-Others-1, DGX_H100-4_GPUs-PyTorch-DeepSeek-1" --disable-fail-fast |
|
PR_Github #25604 [ run ] triggered by Bot. Commit: |
|
PR_Github #25595 [ run ] completed with state |
|
/bot run --disable-fail-fast --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-1, GB200-8_GPUs-2_Nodes-PyTorch-2, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-1, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-2, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-3, GB200-4_GPUs-PyTorch-1, GB200-4_GPUs-PyTorch-Post-Merge-1, DGX_H100-2_GPUs-PyTorch-Others-1, DGX_H100-4_GPUs-PyTorch-DeepSeek-1" |
|
PR_Github #25605 [ run ] triggered by Bot. Commit: |
|
PR_Github #25604 [ run ] completed with state |
|
/bot run --disable-fail-fast --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-1, GB200-8_GPUs-2_Nodes-PyTorch-2, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-1, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-2, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-3, GB200-4_GPUs-PyTorch-1, GB200-4_GPUs-PyTorch-Post-Merge-1, DGX_H100-2_GPUs-PyTorch-Others-1, DGX_H100-4_GPUs-PyTorch-DeepSeek-1" |
|
PR_Github #25618 [ run ] triggered by Bot. Commit: |
|
PR_Github #25605 [ run ] completed with state |
|
PR_Github #25618 [ run ] completed with state |
|
/bot skip --comment "Partial testing is sufficient" |
|
PR_Github #25677 [ skip ] triggered by Bot. Commit: |
|
PR_Github #25677 [ skip ] completed with state |
Signed-off-by: Yanchao Lu <[email protected]> Co-authored-by: Matt Lefebvre <[email protected]>
3 participants
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.