Add AttentionOp #708
Draft
Add AttentionOp #708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yizhuoz004
commented
Oct 31, 2025
| dnf install -y \ | ||
| which wget gcc zlib-devel bzip2 bzip2-devel readline-devel sqlite \ | ||
| sqlite-devel xz xz-devel libffi-devel curl git ncurses-devel \ | ||
| openssh-clients libcudnn8-devel zip jq \ |
Collaborator
Author
There was a problem hiding this comment.
cudnn8 conflicts with cudnn9 in the base container.
yizhuoz004
commented
Oct 31, 2025
| //===----------------------------------------------------------------------===// | ||
|
|
||
| bool tensorrt::AttentionOp::isValidForTensorRTVersion( | ||
| int64_t trtMajorVersion) { |
Collaborator
Author
There was a problem hiding this comment.
We should also check the minor version here.
Collaborator
Author
There was a problem hiding this comment.
@christopherbate Could you advise if there's a convenient way to do this? Thanks!
mlir-tensorrt/tensorrt/include/mlir-tensorrt-dialect/TensorRT/IR/TensorRTEnums.td
Show resolved
Hide resolved
yizhuoz004
commented
Nov 11, 2025
yizhuoz004
force-pushed
the
mlir-trt-attention
branch
3 times, most recently
from
225ba18 to
cffa3a2
Compare
yizhuoz004
force-pushed
the
mlir-trt-attention
branch
from
cffa3a2 to
dcfc0c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.