Skip to content

Conversation

@matthewfl
Copy link
Contributor

This PR adds a Dockerfile and a run_docker.sh shell script to create an environment for building the mlir-tensorrt project.

Note: the mlir-tensorrt project does not build on ubuntu 25.04 out of the box currently due to new error messages from the newer version of clang. Similarly, mlir-tensorrt does not build on ubuntu 24.04 as it requires a newer version of cuda-toolkit than was is installed in ubuntu by default. Additionally, there are are a number of dependencies that are required that I did not see listed in a central location.

@shelkesagar29
Copy link
Collaborator

Hi @matthewfl
Thanks for PR. We have .devcontainer/<rocky/ubunu>/decontainer.json inside mlir-tensorrt project. This way of creating docker was adopted because of use of VSCode for project development.

However, you can build docker image outside of VSCode using devcontainer.json. Please refer to https://github.com/devcontainers/cli and let me know if this doesn't serve the purpose.

@shelkesagar29 shelkesagar29 added the mlir-tensorrt Pull request for the mlir-tensorrt project label Jul 28, 2025
@matthewfl
Copy link
Contributor Author

Hi @shelkesagar29,

Thanks for the reply. It seems that I can get the devcontainer working using the cli command you linked.

It might be nice to add a reference to devcontainer to your contributing.md file.

I will close this PR as it is unnecessary.

@matthewfl matthewfl closed this Jul 28, 2025
@shelkesagar29
Copy link
Collaborator

Hi @shelkesagar29,

Thanks for the reply. It seems that I can get the devcontainer working using the cli command you linked.

It might be nice to add a reference to devcontainer to your contributing.md file.

I will close this PR as it is unnecessary.

Yes, that is a good point. I will do that.

@shelkesagar29
Copy link
Collaborator

Created document MR
#681

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mlir-tensorrt Pull request for the mlir-tensorrt project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants