Skip to content

#675: Fix OOB negative slice bug #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2025
Merged

#675: Fix OOB negative slice bug #676

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1008567
#675: Fix OOB negative slice bug
akhilg-nv Jul 22, 2025
c5702ca
Add test case
akhilg-nv Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tripy/nvtripy/frontend/ops/slice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,11 +208,19 @@ def get_min(a, b):
else minimum(cast_to_dim_size(a), cast_to_dim_size(b))
)

def get_max(a, b):
return (
max(a, b)
if isinstance(a, int) and isinstance(b, int)
else maximum(cast_to_dim_size(a), cast_to_dim_size(b))
)

if slice_idx.start is not None:
start = to_positive_idx(slice_idx.start)
# If `start` is past the end, clamp it - if we're going backwards, we need to clamp it to a valid value;
# otherwise, we can clamp it out of bounds (which will yield an empty tensor):
start = get_min(start, select(step >= 0, dim_size, dim_size - 1))
start = get_max(start, 0) # if the start is negative and greater than the dimension size, clamp it to 0
else:
start = default_start

Expand Down