[mlir-tensorrt] Update CI to save cache after build #665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shelkesagar29
requested review from
christopherbate,
jhalakpatel,
parthchadha,
pranavm-nvidia and
yizhuoz004
as code owners
yizhuoz004
approved these changes
Jul 1, 2025
christopherbate
approved these changes
Jul 1, 2025
This PR updates mlir-tensorrt CI to save cache after each (normal and ASAN) build. Previously, cache was being saved at the end of job but this is problematic when build needs to run again (which takes long time!) just because of single test failure. Now, `cicd_build.sh` script is separated in build and test phases. Cache is saved immediately after build. This way, even when test fails, next build is faster.
pranavm-nvidia
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates mlir-tensorrt CI to save cache after each (normal and ASAN) build. Previously, cache was being saved at the end of job but this is problematic when build needs to run again (which takes long time!) just because of single test failure.
Now,
cicd_build.shscript is separated in build and test phases. Cache is saved immediately after build. This way, even when test fails, next build is faster.