Adds support for a dimension names attribute for block arguments #649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavm-nvidia
requested review from
christopherbate and
shelkesagar29
as code owners
pranavm-nvidia
force-pushed
the
mlir-trt-dim-names
branch
from
0cd6f43 to
91dbc68
Compare
pranavm-nvidia
commented
May 30, 2025
mlir-tensorrt/tensorrt/test/Target/TensorRT/dimension_names.mlir
Outdated
Show resolved
Hide resolved
pranavm-nvidia
requested review from
jhalakpatel,
parthchadha and
yizhuoz004
as code owners
pranavm-nvidia
force-pushed
the
mlir-trt-dim-names
branch
from
0b1ec22 to
b51b122
Compare
pranavm-nvidia
force-pushed
the
mlir-trt-dim-names
branch
from
b51b122 to
006bde8
Compare
shelkesagar29
approved these changes
Jun 11, 2025
Collaborator
shelkesagar29
left a comment
shelkesagar29
left a comment
There was a problem hiding this comment.
LGTM except few comments.
mlir-tensorrt/tensorrt/lib/Target/TensorRTEncodingOpInterface/NetworkEncoder.cpp
Outdated
Show resolved
Hide resolved
mlir-tensorrt/tensorrt/test/Target/TensorRT/dimension_names.mlir
Outdated
Show resolved
Hide resolved
mlir-tensorrt/tensorrt/lib/Target/TensorRTEncodingOpInterface/NetworkEncoder.cpp
Outdated
Show resolved
Hide resolved
mlir-tensorrt/tensorrt/lib/Target/TensorRTEncodingOpInterface/NetworkEncoder.cpp
Outdated
Show resolved
Hide resolved
mlir-tensorrt/tensorrt/lib/Target/TensorRTEncodingOpInterface/NetworkEncoder.cpp
Outdated
Show resolved
Hide resolved
mlir-tensorrt/tensorrt/lib/Target/TensorRTEncodingOpInterface/NetworkEncoder.cpp
Outdated
Show resolved
Hide resolved
pranavm-nvidia
force-pushed
the
mlir-trt-dim-names
branch
2 times, most recently
from
34df3e2 to
01ce506
Compare
mlir-tensorrt/tensorrt/lib/Target/TensorRTEncodingOpInterface/NetworkEncoder.cpp
Outdated
Show resolved
Hide resolved
Adds support for a dimension names attribute which is used to set dimension names in TensorRT. This conveys that the dimensions are equal at runtime.
pranavm-nvidia
force-pushed
the
mlir-trt-dim-names
branch
from
01ce506 to
5e8bfb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for a dimension names attribute which is used to set dimension names in TensorRT. This conveys that the dimensions are equal at runtime.