Various improvements to SAMv2 demo #646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates docker run instructions to support debugging with gdb and removes an unnecessary stream synchronization call in the SAMv2 image encoder.
- Updates docker commands in CONTRIBUTING.md by adding --cap-add=SYS_PTRACE
- Removes an unneeded tp.default_stream().synchronize() call in the SAMv2 image encoder
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tripy/examples/segment-anything-model-v2/sam2/modeling/backbones/image_encoder.py | Removed stream synchronization in the compiled execution branch |
| tripy/CONTRIBUTING.md | Updated docker run commands with --cap-add=SYS_PTRACE for enhanced debugging |
Files not reviewed (1)
- tripy/docs/packages.html: Language not supported
tripy/examples/segment-anything-model-v2/sam2/modeling/backbones/image_encoder.py
Show resolved
Hide resolved
pranavm-nvidia
changed the title
Collaborator
Author
|
Pulled out the package index changes into a separate PR: #647 |
pranavm-nvidia
force-pushed
the
upd-packages
branch
2 times, most recently
from
a2851c7 to
f0ab3c7
Compare
…yTorch operations Adds `--cap-add=SYS_PTRACE` to docker commands so that `gdb` can be used with child processes in the container. Removes unnecessary stream synchronize in SAMv2 demo.
pranavm-nvidia
force-pushed
the
upd-packages
branch
from
59cf353 to
115d27a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
--cap-add=SYS_PTRACEto docker commands so thatgdbcan be used with child processes in the container.Removes unnecessary stream synchronize in SAMv2 demo.