Change topK to 10 in nanoGPT sample #363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yizhuoz004
force-pushed
the
dev-yizhuoz-fix-l1-again
branch
4 times, most recently
from
e0aba00 to
4d8c27c
Compare
parthchadha
approved these changes
Nov 13, 2024
yizhuoz004
force-pushed
the
dev-yizhuoz-fix-l1-again
branch
4 times, most recently
from
3813ac8 to
fdc83eb
Compare
yizhuoz004
force-pushed
the
dev-yizhuoz-fix-l1-again
branch
from
fdc83eb to
347bcbb
Compare
Signed-off-by: yizhuoz004 <[email protected]>
Signed-off-by: yizhuoz004 <[email protected]>
Signed-off-by: yizhuoz004 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: top K helps stablize the result a bit but not much, the result of
int8-weight-onlycan vary among several outputs on CI machine, but cannot be reproduced locally. Worth looking into this issue later on.