Improves error messages for incorrect types #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavm-nvidia
force-pushed
the
improve-type-errors
branch
from
360375f to
593b28a
Compare
Cleans up the display of type annotations and includes module names for arguments
provided from outside of Tripy or Python builtins.
Before (line breaks added for clarity):
```
Not a valid overload because: For parameter: 'other', expected an instance of type:
'typing.Union[ForwardRef('tripy.Tensor'), ForwardRef('tripy.types.NestedNumberSequence')]'
but got argument of type: 'Tensor'.
```
After:
```
Not a valid overload because: For parameter: 'other', expected an instance of type:
'Union[tripy.Tensor, tripy.types.NestedNumberSequence]'
but got argument of type: 'torch.Tensor'.
```
pranavm-nvidia
force-pushed
the
improve-type-errors
branch
from
593b28a to
4b471cd
Compare
jhalakpatel
approved these changes
Oct 1, 2024
slyubomirsky
approved these changes
Oct 1, 2024
parthchadha
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up the display of type annotations and includes module names for arguments provided from outside of Tripy or Python builtins.
Before (line breaks added for clarity):
After: