Skip to content

Print fully qualified type name in case of type mismatch #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Print fully qualified type name in case of type mismatch #239

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions tripy/tripy/function_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,11 @@ def matches_arg_types(self, args, kwargs) -> "Result":

def sanitize_name(annotation):
# typing module annotations are likely to be better when pretty-printed due to including subscripts
return annotation if annotation.__module__ == "typing" else annotation.__qualname__
return (
annotation
if annotation.__module__ == "typing"
else f"{annotation.__module__}.{annotation.__qualname__}"
)

def render_arg_type(arg: Any) -> str:
# it is more useful to report more detailed types for sequences/tuples in error messages
Expand All @@ -116,7 +120,7 @@ def render_arg_type(arg: Any) -> str:
return f"List[Union[{', '.join(arg_types)}]]"
if isinstance(arg, Tuple):
return f"Tuple[{', '.join(map(render_arg_type, arg))}]"
return type(arg).__qualname__
return f"{type(arg).__module__}.{type(arg).__qualname__}"

def matches_type(name: str, annotation: type, arg: Any) -> bool:
from collections.abc import Sequence as ABCSequence
Expand Down