Add checks for non-canonical strides #236
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhalakpatel
force-pushed
the
jhalakp-non-linear-strides
branch
2 times, most recently
from
12376ed to
5863d9b
Compare
jhalakpatel
force-pushed
the
jhalakp-non-linear-strides
branch
from
5863d9b to
f906ce4
Compare
jhalakpatel
changed the title
parthchadha
reviewed
Sep 30, 2024
jhalakpatel
force-pushed
the
jhalakp-non-linear-strides
branch
10 times, most recently
from
7770846 to
c21f8aa
Compare
parthchadha
reviewed
Oct 3, 2024
jhalakpatel
commented
Oct 3, 2024
jhalakpatel
force-pushed
the
jhalakp-non-linear-strides
branch
from
c21f8aa to
c8cea81
Compare
jhalakpatel
changed the title
jhalakpatel
force-pushed
the
jhalakp-non-linear-strides
branch
2 times, most recently
from
b27b41e to
cc2b071
Compare
parthchadha
approved these changes
Oct 3, 2024
jhalakpatel
force-pushed
the
jhalakp-non-linear-strides
branch
2 times, most recently
from
3379879 to
01a005c
Compare
jhalakpatel
force-pushed
the
jhalakp-non-linear-strides
branch
from
01a005c to
96bdf1d
Compare
MLIR-TensorRT requires strides for function arguments and results in canonical order. NVIDIA#252 adds a check to validate memref stride against a canonical stride order. In Tripy, memref strides are derived from framework DL Pack tensors. Creating a memref with a non-canonical DL Pack tensor stride throws an exception. Add a try-catch block to catch such an exception and augment with suggestions on creating a DL Pack tensor with canonical stride for Tripy-supported frameworks. Add unit tests to create a non-canonical stride tensor to validate exceptions and suggestions.
jhalakpatel
force-pushed
the
jhalakp-non-linear-strides
branch
from
96bdf1d to
1c1a13f
Compare
pranavm-nvidia
approved these changes
Oct 15, 2024
Collaborator
Author
|
Closing this PR in favor of #273 since this one is running into CI failure due to fork based developement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#229
MLIR-TensorRT requires strides for function arguments and results in canonical order.
#252 adds a check to validate memref stride against a canonical stride order. In Tripy, memref strides are derived from framework DL Pack tensors. Creating a memref with a non-canonical DL Pack tensor stride throws an exception.
Add a try-catch block to catch such an exception and augment with suggestions on creating a DL Pack tensor with canonical stride for Tripy-supported frameworks.
Add unit tests to create a non-canonical stride tensor to validate exceptions and suggestions.