Various bug fixes to fix L1 tests #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavm-nvidia
commented
Sep 26, 2024
pranavm-nvidia
force-pushed
the
fix-l1
branch
from
ad9fd94 to
bcf91d0
Compare
pranavm-nvidia
force-pushed
the
fix-l1
branch
from
bcf91d0 to
dda41aa
Compare
pranavm-nvidia
force-pushed
the
fix-l1
branch
3 times, most recently
from
ff06088 to
51df644
Compare
slyubomirsky
approved these changes
Sep 30, 2024
Contributor
slyubomirsky
left a comment
slyubomirsky
left a comment
There was a problem hiding this comment.
Some minor comments, though we could leave broader discussion to #233. Thank you for the various corrections and improvements.
- Adds tests to ensure we only use ASCII characters in our code and markdown files.
Some non-ASCII characters that look like ASCII characters were breaking tests
that make assumptions about the encoding.
- Updates dtype constraint tests to properly construct inputs for various APIs.
- Moves dtype constraint tests to L0 since they only add about 20 seconds and were
breaking very often otherwise.
- Updates binary elementwise ops to only return `ShapeScalar`s if *all* inputs are also
`ShapeScalar`s.
- Corrects dtype constraints for several APIs.
- Simplifies `mean` implementation.
- Corrects type annotations for some APIs and introduces a `ShapeLike` type.
- Adds support for `Optional` during type checking.
- Updates `convert_inputs_to_tensors` to now potentially convert tensors to
`Tensor` subclasses. See the note in the code for details on the logic.
pranavm-nvidia
force-pushed
the
fix-l1
branch
from
51df644 to
9fccf44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests to ensure we only use ASCII characters in our code and markdown files. Some non-ASCII characters that look like ASCII characters were breaking tests that make assumptions about the encoding.
Updates dtype constraint tests to properly construct inputs for various APIs.
Moves dtype constraint tests to L0 since they only add about 20 seconds and were breaking very often otherwise.
Updates binary elementwise ops to only return
ShapeScalars if all inputs are alsoShapeScalars.Corrects dtype constraints for several APIs.
Simplifies
meanimplementation.Corrects type annotations for some APIs and introduces a
ShapeLiketype.Adds support for
Optionalduring type checking.Updates
convert_inputs_to_tensorsto now potentially convert tensors toTensorsubclasses. See the note in the code for details on the logic.