Adds performance testing #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavm-nvidia
requested review from
jhalakpatel,
parthchadha,
shelkesagar29 and
yizhuoz004
as code owners
pranavm-nvidia
force-pushed
the
perf-tests
branch
4 times, most recently
from
9743493 to
467e132
Compare
pranavm-nvidia
force-pushed
the
perf-tests
branch
3 times, most recently
from
a22524e to
fc0d31f
Compare
parthchadha
reviewed
Oct 8, 2024
pranavm-nvidia
force-pushed
the
perf-tests
branch
4 times, most recently
from
a5584db to
a51b47f
Compare
Adds three kinds of performance tests:
1. Regression testing, which will compare current Tripy performance to historical data
to ensure we don't regress. This can currently only be done in CI.
2. Comparative testing, which will compare Tripy and `torch.compile`
3. Overhead testing, which will check the overhead introduced by Tripy as compared
to running the underlying MLIR executable by itself. This is done by measuring
how long it takes to run an empty executable since in that case, all the time
is taken by the Tripy wrapper code.
Removes `utils.volume` since it can be easily replaced with `math.prod`.
Applies various optimizations based on data from NSight traces. For example, this includes removing all assertions in the critical path and reducing the amount of Python code involved as much as possible.
pranavm-nvidia
force-pushed
the
perf-tests
branch
from
a51b47f to
7269ac0
Compare
parthchadha
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds performance testing, along with various other improvements and fixes. I recommend reviewing this MR one commit at a time. Each commit is self-contained.