Scope the locality guard to the namespace - #365
Merged
Conversation
rng1995
force-pushed
the
agent/yara-locality-namespace
branch
from
August 12, 2026 05:11
f805215 to
bba2aa8
Compare
rng1995
commented
Aug 12, 2026
rng1995
marked this pull request as ready for review
August 12, 2026 08:28
rng1995
force-pushed
the
agent/yara-locality-namespace
branch
from
August 12, 2026 08:36
c5e93e4 to
d7b45d1
Compare
keshprad
force-pushed
the
agent/yara-locality-namespace
branch
from
August 14, 2026 21:12
1c61923 to
550d358
Compare
Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com>
Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com>
keshprad
force-pushed
the
agent/yara-locality-namespace
branch
from
August 14, 2026 22:47
415115b to
c3c437d
Compare
keshprad
approved these changes
Aug 14, 2026
keshprad
left a comment
Member
There was a problem hiding this comment.
Reviewed the namespace-scoped locality guard, packaged namespace precedence, and the rebase resolution preserving byte-offset handling from #364. The focused YARA suite passes 64 tests, Ruff passes, all required CI checks are green, and the sole review thread is resolved. No blocking findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent_skillsnamespace.Problem
SkillSpector compiles built-in and user-supplied YARA files into separate namespaces, but the locality guard introduced for
agent_skill_destructive_autonomous_actionspreviously checked onlymatch.rule.Because YARA rule names need only be unique within a namespace, a user rule can legally use the same name with unrelated string identifiers and semantics. The built-in post-filter would then inspect that custom match, find no built-in destructive/autonomy identifiers, and silently discard a valid user-defined finding.
Implementation
agent_skills.Security invariants
rm -rf /detection remains unconditionally blocking.User impact
Custom YARA rules retain their declared behavior even when their rule names collide with built-in rules in a different namespace. The packaged destructive-action guard continues to suppress only its intended cross-context false positives.
Validation
61 passedintests/nodes/analyzers/test_static_yara.py.git diff --checkpassed.Files changed
src/skillspector/nodes/analyzers/static_yara.pytests/nodes/analyzers/test_static_yara.py