fix(cli): pass link.label to formatTerminalHyperlink instead of link.url#2506
fix(cli): pass link.label to formatTerminalHyperlink instead of link.url#2506ColinM-sys wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
formatTerminalHyperlink(label, url) takes the display text as the first argument. The structured-link branch was passing link.url as both arguments, so terminal hyperlinks displayed the raw URL string as the clickable label instead of the configured link.label text. The plain-URL body branch at line 160 correctly passes the line text as the label. The structured-link branch now does the same. Signed-off-by: ColinM-sys <cmcdonough@50words.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
✨ Thanks for submitting this pull request that proposes a way to fix a bug in the NemoClaw CLI, where terminal hyperlinks were displaying the raw URL instead of the configured label text. |
`formatTerminalHyperlink(label, url)` takes the display text as its
first argument. The structured-link branch in `printUsageNotice` was
calling `formatTerminalHyperlink(link.url, link.url)`, passing the
URL as both arguments — so terminal hyperlinks displayed the raw URL
string as the clickable label instead of the configured `link.label`
text.
The plain-URL body branch at line 160 correctly passes the text as the
label. This brings the structured-link branch into line with it.
Signed-off-by: ColinM-sys cmcdonough@50words.com
Summary by CodeRabbit