Skip to content

fix(cli): pass link.label to formatTerminalHyperlink instead of link.url#2506

Open
ColinM-sys wants to merge 1 commit intoNVIDIA:mainfrom
ColinM-sys:fix/usage-notice-hyperlink-label
Open

fix(cli): pass link.label to formatTerminalHyperlink instead of link.url#2506
ColinM-sys wants to merge 1 commit intoNVIDIA:mainfrom
ColinM-sys:fix/usage-notice-hyperlink-label

Conversation

@ColinM-sys
Copy link
Copy Markdown
Contributor

@ColinM-sys ColinM-sys commented Apr 27, 2026

`formatTerminalHyperlink(label, url)` takes the display text as its
first argument. The structured-link branch in `printUsageNotice` was
calling `formatTerminalHyperlink(link.url, link.url)`, passing the
URL as both arguments — so terminal hyperlinks displayed the raw URL
string as the clickable label instead of the configured `link.label`
text.

The plain-URL body branch at line 160 correctly passes the text as the
label. This brings the structured-link branch into line with it.

Signed-off-by: ColinM-sys cmcdonough@50words.com

Summary by CodeRabbit

  • Bug Fixes
    • Terminal hyperlink display corrected to show the configured label text instead of the full URL as the visible text.

formatTerminalHyperlink(label, url) takes the display text as the first
argument. The structured-link branch was passing link.url as both
arguments, so terminal hyperlinks displayed the raw URL string as the
clickable label instead of the configured link.label text.

The plain-URL body branch at line 160 correctly passes the line text
as the label. The structured-link branch now does the same.

Signed-off-by: ColinM-sys <cmcdonough@50words.com>
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 27, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 82f39a1a-6a87-4772-9a1a-d1d1e7839f37

📥 Commits

Reviewing files that changed from the base of the PR and between 6f7f0c6 and 6a4e238.

📒 Files selected for processing (1)
  • src/lib/usage-notice.ts

📝 Walkthrough

Walkthrough

The printUsageNotice function now displays configured hyperlink labels instead of URLs in terminal OSC8 hyperlinks. The rendered text now uses link.label while maintaining link.url as the actual hyperlink target.

Changes

Cohort / File(s) Summary
Hyperlink Display Logic
src/lib/usage-notice.ts
Modified OSC8 hyperlink rendering to use link.label as displayed text instead of link.url, improving visual presentation while preserving the underlying hyperlink target.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A label now shines where the URL once lay,
Terminal links wear their names in a friendlier way,
No more cryptic addresses in bright clickable blue—
Just clean, simple labels, for me and for you! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: passing link.label instead of link.url to formatTerminalHyperlink, which is a one-line fix in usage-notice.ts.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@wscurran wscurran added bug Something isn't working NemoClaw CLI Use this label to identify issues with the NemoClaw command-line interface (CLI). labels Apr 27, 2026
@wscurran
Copy link
Copy Markdown
Contributor

✨ Thanks for submitting this pull request that proposes a way to fix a bug in the NemoClaw CLI, where terminal hyperlinks were displaying the raw URL instead of the configured label text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working NemoClaw CLI Use this label to identify issues with the NemoClaw command-line interface (CLI).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants