Skip to content

fix(validation): add nvidia-nim to shouldSkipResponsesProbe#2505

Open
ColinM-sys wants to merge 1 commit intoNVIDIA:mainfrom
ColinM-sys:fix/validation-skip-responses-probe-nvidia-nim
Open

fix(validation): add nvidia-nim to shouldSkipResponsesProbe#2505
ColinM-sys wants to merge 1 commit intoNVIDIA:mainfrom
ColinM-sys:fix/validation-skip-responses-probe-nvidia-nim

Conversation

@ColinM-sys
Copy link
Copy Markdown
Contributor

@ColinM-sys ColinM-sys commented Apr 27, 2026

`nvidia-prod` and `nvidia-nim` map to the same NVIDIA endpoint config
in `inference-config.ts` — same base URL, same credential env, same
`providerLabel: "NVIDIA Endpoints"`. Neither supports `/v1/responses`.

`nvidia-prod` was already listed in `shouldSkipResponsesProbe` but
`nvidia-nim` was missing, so sandboxes onboarded with the `nvidia-nim`
provider incorrectly ran the Responses probe against an endpoint that
does not expose it.

Signed-off-by: ColinM-sys cmcdonough@50words.com

Summary by CodeRabbit

  • New Features

    • The nvidia-nim inference provider is now properly supported in the setup wizard's response validation logic, with consistent handling across all supported providers.
  • Tests

    • Added unit test coverage to verify nvidia-nim provider response validation behavior.

nvidia-prod and nvidia-nim both map to the same NVIDIA endpoint config
in inference-config.ts (same URL, same credential, same providerLabel).
Neither supports /v1/responses. nvidia-prod was already listed but
nvidia-nim was missing, so sandboxes onboarded with the nvidia-nim
provider incorrectly ran the Responses probe against an endpoint that
does not expose it.

Signed-off-by: ColinM-sys <cmcdonough@50words.com>
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 27, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b35e4b60-896e-417a-a42a-a1db8e259221

📥 Commits

Reviewing files that changed from the base of the PR and between 6f7f0c6 and 0bd5ad5.

📒 Files selected for processing (2)
  • src/lib/validation.test.ts
  • src/lib/validation.ts

📝 Walkthrough

Walkthrough

Extended the shouldSkipResponsesProbe function to treat the "nvidia-nim" provider the same as "nvidia-prod" and "gemini-api", skipping OpenAI Responses API probing. Added corresponding unit test to verify this behavior.

Changes

Cohort / File(s) Summary
Responses Probe Skip Logic
src/lib/validation.ts, src/lib/validation.test.ts
Extended shouldSkipResponsesProbe to skip responses probing for "nvidia-nim" provider alongside existing skip conditions. Added unit test verifying nvidia-nim is treated identically to nvidia-prod.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A provider joins the skip list with grace,
nvidia-nim finds its proper place,
Responses probe need not probe at all,
Tests confirm this for one and all! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding nvidia-nim to the shouldSkipResponsesProbe function, which matches the actual code modifications in both validation.ts and validation.test.ts.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@wscurran wscurran added bug Something isn't working dependencies Pull requests that update a dependency file Provider: NVIDIA Use this label to identify issues with the NVIDIA inference provider integration. labels Apr 27, 2026
@wscurran
Copy link
Copy Markdown
Contributor

✨ Thanks for submitting this pull request that proposes a way to fix a bug where the nvidia-nim provider was missing from the shouldSkipResponsesProbe list. This identifies a bug and proposes a change to add nvidia-nim to the list, ensuring consistent handling across all supported providers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependencies Pull requests that update a dependency file Provider: NVIDIA Use this label to identify issues with the NVIDIA inference provider integration.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants