Skip to content

test(validation): replace stale provider ID in shouldSkipResponsesProbe test#2504

Open
ColinM-sys wants to merge 1 commit intoNVIDIA:mainfrom
ColinM-sys:fix/validation-test-stale-anthropic-provider-id
Open

test(validation): replace stale provider ID in shouldSkipResponsesProbe test#2504
ColinM-sys wants to merge 1 commit intoNVIDIA:mainfrom
ColinM-sys:fix/validation-test-stale-anthropic-provider-id

Conversation

@ColinM-sys
Copy link
Copy Markdown
Contributor

@ColinM-sys ColinM-sys commented Apr 27, 2026

The fixture on line 289 used `"anthropic-api"` which does not exist
anywhere in the codebase as a provider ID. The real Anthropic provider
ID used throughout `inference-config.ts`, `onboard.ts`, and
`inference-health.ts` is `"anthropic-prod"`.

The test still passed because `shouldSkipResponsesProbe` returns
`false` for any unrecognised string, so the assertion was never
actually exercising the Anthropic provider path — it was passing
vacuously.

Signed-off-by: ColinM-sys cmcdonough@50words.com

Summary by CodeRabbit

  • Tests
    • Updated test coverage for provider validation to ensure proper validation across different provider configurations.

…be test

The fixture used "anthropic-api" which does not exist anywhere in the
codebase as a provider ID. The actual Anthropic provider ID used
throughout inference-config.ts, onboard.ts, and inference-health.ts
is "anthropic-prod". The test still passed because shouldSkipResponsesProbe
returns false for any unrecognised string, so the assertion was never
actually testing the Anthropic provider.

Signed-off-by: ColinM-sys <cmcdonough@50words.com>
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 27, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 48050bdb-671f-436a-9dd2-02641937c334

📥 Commits

Reviewing files that changed from the base of the PR and between 6f7f0c6 and b5d3171.

📒 Files selected for processing (1)
  • src/lib/validation.test.ts

📝 Walkthrough

Walkthrough

A test case for the shouldSkipResponsesProbe function is updated to verify behavior with the provider string "anthropic-prod" instead of "anthropic-api", maintaining the same expected result.

Changes

Cohort / File(s) Summary
Test Provider String Update
src/lib/validation.test.ts
Updated test input for "other providers" case from "anthropic-api" to "anthropic-prod" while preserving expected behavior validation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A single string does twist and turn,
From "anthropic-api" we learn,
To "anthropic-prod" it now does go,
The test still passes—on we flow!
One line changed, the logic stays true,
Testing tweaks in all we do! 🧪✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: replacing a stale provider ID in a test, matching the actual content of the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@wscurran wscurran added CI/CD Use this label to identify issues with NemoClaw CI/CD pipeline or GitHub Actions. enhancement: testing Use this label to identify requests to improve NemoClaw test coverage. dependencies Pull requests that update a dependency file labels Apr 27, 2026
@wscurran
Copy link
Copy Markdown
Contributor

✨ Thanks for submitting this pull request that proposes a way to update the test coverage for provider validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Use this label to identify issues with NemoClaw CI/CD pipeline or GitHub Actions. dependencies Pull requests that update a dependency file enhancement: testing Use this label to identify requests to improve NemoClaw test coverage.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants