test(validation): replace stale provider ID in shouldSkipResponsesProbe test#2504
test(validation): replace stale provider ID in shouldSkipResponsesProbe test#2504ColinM-sys wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
…be test The fixture used "anthropic-api" which does not exist anywhere in the codebase as a provider ID. The actual Anthropic provider ID used throughout inference-config.ts, onboard.ts, and inference-health.ts is "anthropic-prod". The test still passed because shouldSkipResponsesProbe returns false for any unrecognised string, so the assertion was never actually testing the Anthropic provider. Signed-off-by: ColinM-sys <cmcdonough@50words.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA test case for the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
✨ Thanks for submitting this pull request that proposes a way to update the test coverage for provider validation. |
The fixture on line 289 used `"anthropic-api"` which does not exist
anywhere in the codebase as a provider ID. The real Anthropic provider
ID used throughout `inference-config.ts`, `onboard.ts`, and
`inference-health.ts` is `"anthropic-prod"`.
The test still passed because `shouldSkipResponsesProbe` returns
`false` for any unrecognised string, so the assertion was never
actually exercising the Anthropic provider path — it was passing
vacuously.
Signed-off-by: ColinM-sys cmcdonough@50words.com
Summary by CodeRabbit