Skip to content

fix(ci): add --ignore-scripts to plugin npm install in brev launchable#2501

Open
ColinM-sys wants to merge 1 commit intoNVIDIA:mainfrom
ColinM-sys:fix/brev-npm-ignore-scripts
Open

fix(ci): add --ignore-scripts to plugin npm install in brev launchable#2501
ColinM-sys wants to merge 1 commit intoNVIDIA:mainfrom
ColinM-sys:fix/brev-npm-ignore-scripts

Conversation

@ColinM-sys
Copy link
Copy Markdown
Contributor

@ColinM-sys ColinM-sys commented Apr 27, 2026

Every other `npm install` in `brev-launchable-ci-cpu.sh` passes
`--ignore-scripts` (line 274), and the same flag is used throughout
`install.sh` (lines 857, 859, 888, 890). The plugin build step at
line 286 was missing it.

Without the flag, postinstall scripts from NemoClaw's transitive
dependencies can execute as the Brev VM user during launchable boot.
This brings the script into line with the project's established
practice.

Signed-off-by: ColinM-sys cmcdonough@50words.com

Summary by CodeRabbit

  • Chores
    • Updated continuous integration build configuration to optimize TypeScript plugin dependency installation during the automated build process. This modification enhances build efficiency and stability by streamlining the dependency resolution process, resulting in faster and more reliable builds across all development environments.

Every other npm install in this file already passes --ignore-scripts
(line 274, and install.sh:857, 859, 888, 890). The plugin build step
at line 286 was missing the flag, allowing postinstall scripts from
nemoclaw's transitive dependencies to execute as the Brev VM user
during launchable boot.

Signed-off-by: ColinM-sys <cmcdonough@50words.com>
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 27, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 0cb714c7-1dd3-4e68-b0a6-e571a961ec8c

📥 Commits

Reviewing files that changed from the base of the PR and between 6f7f0c6 and 64ae739.

📒 Files selected for processing (1)
  • scripts/brev-launchable-ci-cpu.sh

📝 Walkthrough

Walkthrough

A CI/CD script is modified to add the --ignore-scripts flag to an npm install command when installing TypeScript plugin dependencies, preventing lifecycle scripts from executing during the installation phase.

Changes

Cohort / File(s) Summary
Build Script Configuration
scripts/brev-launchable-ci-cpu.sh
Added --ignore-scripts flag to npm install command for nemoclaw plugin dependencies, preventing lifecycle scripts from running during dependency installation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

Hop, hop, a flag so small and bright,
--ignore-scripts keeps builds light,
No needless scripts will run and play,
Just clean installs to save the day! 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and specifically describes the main change: adding --ignore-scripts flag to npm install for the plugin in the brev launchable CI script.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@wscurran wscurran added CI/CD Use this label to identify issues with NemoClaw CI/CD pipeline or GitHub Actions. dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Apr 27, 2026
@wscurran
Copy link
Copy Markdown
Contributor

✨ Thanks for submitting this pull request that proposes a way to improve the CI build configuration by adding the --ignore-scripts flag to the plugin npm install step, enhancing build efficiency and stability.

@wscurran wscurran added the Platform: Brev Support for Brev deployment label Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Use this label to identify issues with NemoClaw CI/CD pipeline or GitHub Actions. dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code Platform: Brev Support for Brev deployment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants