fix(ci): add --ignore-scripts to plugin npm install in brev launchable#2501
fix(ci): add --ignore-scripts to plugin npm install in brev launchable#2501ColinM-sys wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Every other npm install in this file already passes --ignore-scripts (line 274, and install.sh:857, 859, 888, 890). The plugin build step at line 286 was missing the flag, allowing postinstall scripts from nemoclaw's transitive dependencies to execute as the Brev VM user during launchable boot. Signed-off-by: ColinM-sys <cmcdonough@50words.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA CI/CD script is modified to add the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
✨ Thanks for submitting this pull request that proposes a way to improve the CI build configuration by adding the --ignore-scripts flag to the plugin npm install step, enhancing build efficiency and stability. |
Every other `npm install` in `brev-launchable-ci-cpu.sh` passes
`--ignore-scripts` (line 274), and the same flag is used throughout
`install.sh` (lines 857, 859, 888, 890). The plugin build step at
line 286 was missing it.
Without the flag, postinstall scripts from NemoClaw's transitive
dependencies can execute as the Brev VM user during launchable boot.
This brings the script into line with the project's established
practice.
Signed-off-by: ColinM-sys cmcdonough@50words.com
Summary by CodeRabbit