-
Notifications
You must be signed in to change notification settings - Fork 516
docs(tracing): update and streamline tracing guide #1307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request revises the tracing documentation for NeMo Guardrails, streamlining the configuration process and aligning it with OpenTelemetry best practices. The documentation is restructured to provide clearer guidance for both development and production environments.
- Simplifies tracing configuration by removing complex examples and focusing on minimal configuration
- Adds a comprehensive new tracing guide with detailed OpenTelemetry integration examples
- Aligns with OpenTelemetry best practices where libraries use the API and applications configure the SDK
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
docs/user-guides/tracing.md | New comprehensive tracing guide with quick start, adapter configurations, OpenTelemetry integration examples, and migration guidance |
docs/user-guides/configuration-guide.md | Streamlined tracing section with simplified configuration examples and reference to the detailed tracing guide |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1307 +/- ##
========================================
Coverage 70.45% 70.45%
========================================
Files 161 161
Lines 16214 16214
========================================
Hits 11423 11423
Misses 4791 4791
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Documentation preview |
fix hyperlink
[GENERATED BY COPILOT]
This pull request revises the tracing documentation for NeMo Guardrails, streamlining the configuration process and aligning it with OpenTelemetry best practices. Key changes include simplifying the tracing setup, emphasizing application-level SDK configuration, and providing detailed examples for production and development environments.
Updates to Tracing Documentation:
Simplification of Configuration:
docs/user-guides/configuration-guide.md
. The new approach focuses on enabling tracing inconfig.yml
with minimal configuration and highlights the FileSystem and OpenTelemetry adapters for development and production use.New Tracing Guide:
docs/user-guides/tracing.md
, which provides a comprehensive guide to tracing, including quick start instructions, adapter types, OpenTelemetry integration, and setup examples for development and production environments.OpenTelemetry Best Practices:
register_otel_exporter()
are noted, with migration examples provided.Enhanced Ecosystem Compatibility:
Support for Custom Adapters:
InteractionLogAdapter
classes for specialized backends or formats.#1287