Remove sqlitedict from requirements and import guard #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chtruong814
reviewed
Apr 18, 2025
chtruong814
left a comment
chtruong814
left a comment
There was a problem hiding this comment.
Thanks for doing this! Had some minor comments.
| print( | ||
| "Eval harness with sqlitedict is deprecated. Sqlitedict has known vulnerability GHSA-g4r7-86gm-pgqc" | ||
| ) | ||
| HAS_SQLITEDICT = True |
| os.makedirs(os.path.dirname(cache_db), exist_ok=True) | ||
| self.dbdict = SqliteDict(cache_db, autocommit=True) | ||
| if HAS_SQLITEDICT: | ||
| self.dbdict = SqliteDict(cache_db, autocommit=True) |
There was a problem hiding this comment.
It honestly probably won't matter but probably best to set self.dbdict to None sqlite dict does not exist. It looks like in the above CacheHook it's a noopt if dbdict is None.
Collaborator
Author
There was a problem hiding this comment.
Good suggestion, I've introduced an else statement
chtruong814
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.