chore: update comments

Author: mchmarny

distros/kubernetes/nvsentinel/charts/labeler/values.yaml

@@ -25,7 +25,7 @@ logLevel: info
 # will check BOTH this custom label AND the default 'katacontainers.io/kata-runtime' label as
 # input sources for detection. The labeler will then set the output label 
 # 'nvsentinel.dgxc.nvidia.com/kata.enabled' to "true" or "false" based on the detection result.
-# Example: 'io.katacontainers.config.hypervisor.path' to detect Kata via additional label
+# Example: 'custom.kata.label' or 'io.katacontainers.config.runtime.oci_runtime'
 # Note: The input label value must be truthy (case-insensitive): "true", "enabled", "1", or "yes"
 kataLabelOverride: ""
 

distros/kubernetes/nvsentinel/charts/syslog-health-monitor/templates/configmap.yaml

@@ -26,7 +26,7 @@ data:
   # Note: This ConfigMap is shared by both regular and kata DaemonSet variants.
   # Kata detection is handled by the labeler-module which sets the
   # "nvsentinel.dgxc.nvidia.com/kata.enabled" label on nodes. The DaemonSets
-  # use nodeAffinity to deploy the correct variant based on this label.
+  # use nodeSelector to deploy the correct variant based on this label.
   # 
   # Previously, kata-specific journal tags (e.g., "-u containerd.service") were
   # conditionally added here, but these are no longer needed because:

labeler-module/pkg/labeler/labeler_test.go

@@ -559,8 +559,8 @@ func TestLabeler_handlePodEvent(t *testing.T) {
 				require.NoError(t, labeler.Run(ctx), "failed to run labeler")
 			}()
 
-			ok := cache.WaitForCacheSync(ctx.Done(), labeler.informersSynced...)
-			assert.True(t, ok, "failed to wait for cache sync")
+			synced := cache.WaitForCacheSync(ctx.Done(), labeler.informersSynced...)
+			assert.True(t, synced, "failed to wait for cache sync")
 
 			if tt.pod != nil {
 				p, err := cli.CoreV1().Pods(ns.Name).Get(ctx, tt.pod.Name, metav1.GetOptions{})

tests/topology_test.go

@@ -160,24 +160,21 @@ func TestKataTopology(t *testing.T) {
 
 				// Verify the correct DaemonSet variant is scheduled based on kata.enabled
 				nodeValidated := false
+				expectedKataValue := kataEnabled
 				for _, pod := range syslogPods {
 					podKataLabel, hasPodLabel := pod.Labels["nvsentinel.dgxc.nvidia.com/kata"]
-					if kataEnabled == "true" {
-						assert.True(t, hasPodLabel, "Kata node %s has syslog pod without kata label", nodeName)
-						assert.Equal(t, "true", podKataLabel, "Kata node %s has syslog pod with wrong kata label: %s", nodeName, podKataLabel)
-						if !nodeValidated {
+					assert.True(t, hasPodLabel, "Node %s has syslog pod without kata label", nodeName)
+					assert.Equal(t, expectedKataValue, podKataLabel, "Node %s has syslog pod with wrong kata label: expected %s, got %s", nodeName, expectedKataValue, podKataLabel)
+
+					if !nodeValidated {
+						if kataEnabled == "true" {
 							kataNodes[nodeName] = true
-							nodeValidated = true
 							t.Logf("✓ Kata node %s correctly has kata syslog DaemonSet pod", nodeName)
-						}
-					} else {
-						assert.True(t, hasPodLabel, "Regular node %s has syslog pod without kata label", nodeName)
-						assert.Equal(t, "false", podKataLabel, "Regular node %s has syslog pod with wrong kata label: %s", nodeName, podKataLabel)
-						if !nodeValidated {
+						} else {
 							regularNodes[nodeName] = true
-							nodeValidated = true
 							t.Logf("✓ Regular node %s correctly has regular syslog DaemonSet pod", nodeName)
 						}
+						nodeValidated = true
 					}
 				}