Skip to content

Commit e28b29f

Browse files
committed
chore: remove old flag
1 parent d78a6e3 commit e28b29f

File tree

2 files changed

+6
-7
lines changed
  • distros/kubernetes/nvsentinel/charts/syslog-health-monitor/templates
  • health-monitors/syslog-health-monitor

2 files changed

+6
-7
lines changed

distros/kubernetes/nvsentinel/charts/syslog-health-monitor/templates/configmap.yaml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,11 @@ data:
3131
# Previously, kata-specific journal tags (e.g., "-u containerd.service") were
3232
# conditionally added here, but these are no longer needed because:
3333
# 1. Kata detection happens at the deployment level via node labels
34-
# 2. Each DaemonSet variant (regular/kata) handles journal access appropriately
35-
# through its own hostPath mounts and container configuration
36-
# 3. The kata-enabled flag is passed as a command-line argument to configure
37-
# runtime behavior without requiring different ConfigMap content
34+
# 2. Each DaemonSet variant (regular/kata) handles journal access differently:
35+
# - Regular: mounts /var/log (file-based logs)
36+
# - Kata: mounts /run/log/journal and /var/log/journal (systemd journal)
37+
# 3. The kata variant accesses the systemd journal directly, so it can read
38+
# containerd logs without needing special tags or filters in the ConfigMap
3839
log_check_definitions.yaml: |
3940
checks:
4041
- name: "SysLogsXIDError"

health-monitors/syslog-health-monitor/main.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,6 @@ var (
6363
metricsPort = flag.String("metrics-port", "2112", "Port to expose Prometheus metrics on")
6464
xidAnalyserEndpoint = flag.String("xid-analyser-endpoint", "",
6565
"Endpoint to the XID analyser service.")
66-
kataEnabled = flag.String("kata-enabled", "false",
67-
"Indicates if this monitor is running in Kata Containers mode (set by DaemonSet variant).")
6866
)
6967

7068
// ConfigFile matches the top-level structure of the YAML config file
@@ -92,7 +90,7 @@ func run() error {
9290
return fmt.Errorf("NODE_NAME env not set and --node-name flag not provided, cannot run")
9391
}
9492

95-
slog.Info("Configuration", "node", nodeName, "kata-enabled", *kataEnabled)
93+
slog.Info("Configuration", "node", nodeName)
9694

9795
// Root context canceled on SIGINT/SIGTERM so goroutines can exit cleanly.
9896
root := context.Background()

0 commit comments

Comments
 (0)