-
Notifications
You must be signed in to change notification settings - Fork 332
[Speculative Decoding] Refactor EAGLE3 training to YAML-based config and recipe system #1134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
h-guo18
wants to merge
18
commits into
main
Choose a base branch
from
haoguo/eagle-recipelib
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
8bbf26a
yamlize eagle configs
h-guo18 1c57066
separate base config
h-guo18 dcda292
polish
h-guo18 1875722
add file
h-guo18 530256c
move yaml files to recipe lib
h-guo18 c57de62
update readme
h-guo18 4c2451c
add files
h-guo18 b6b9917
rename
h-guo18 01d0569
update test
h-guo18 e52bc6c
revert irrelevant
h-guo18 8756180
address comments
h-guo18 3f126c7
clean up yaml level
h-guo18 6178182
update readme
h-guo18 059598c
udpate simplified flow
h-guo18 101ab0c
polish
h-guo18 9104756
polish
h-guo18 c0330da
update tests
h-guo18 6e4cc17
update launcher, move yaml
h-guo18 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the full nested YAML path for
draft_vocab_size.The runtime schema nests this under
eagle, soeagle_architecture_config.draft_vocab_sizereads like a top-level key. Useeagle.eagle_architecture_config.draft_vocab_sizeto match the actual config structure.Suggested fix
📝 Committable suggestion
🤖 Prompt for AI Agents